Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

macOS on Travis-CI #120

Closed
wants to merge 10 commits into from
Closed

macOS on Travis-CI #120

wants to merge 10 commits into from

Conversation

RMeli
Copy link

@RMeli RMeli commented Sep 16, 2019

Added macOS on Travis-CI, addressing #57.

Linux build passes successfully, macOS build fails because of #119.

@andersx
Copy link
Member

andersx commented Nov 13, 2019

Once again, thank you for the valuable macOS Travis PRl We had a pull request from Casper Steinmann which should have fixed the seg/fault bug on macOS.

I revieved this PR, but this time Tensorflow seems to have changed it's API. I'll see if I can get this fixed now.

@RMeli
Copy link
Author

RMeli commented Nov 14, 2019

Good tho hear that the issue should be solved, thanks!

I think pip is now trying to install TF 2 and should probably be pinned to TF 1.x. I can try to fix this later today or tomorrow.

@andersx
Copy link
Member

andersx commented Nov 14, 2019

Yeah, I think you are right! I don't know what it will require to migrate the code, I think simply requiring tensorflow==1.x be enough for now.

I don't know if the following is a more long-term solution for the TF code:

import tensorflow.compat.v1 as tf
tf.disable_v2_behavior()

Pinging @larsbratholm

@andersx
Copy link
Member

andersx commented Jun 15, 2020

I was trying to get a mac mini for some more internal testing, before I would merge in this change. However, looks like I am not getting one any time soon. I'll look into this again now!

@RMeli
Copy link
Author

RMeli commented Aug 2, 2021

Closing as stale. Feel free to re-open if needed.

@RMeli RMeli closed this Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants