Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qmlearn #82

Merged
merged 27 commits into from
Sep 10, 2018
Merged

Qmlearn #82

merged 27 commits into from
Sep 10, 2018

Conversation

larsbratholm
Copy link
Collaborator

Scikit-learn high level interface. I think that this should be the default interface for qml and that we should hide more low level stuff a bit away.

The implementation is about 3/4 done and is ready for beta testing. 'examples/qmlearn.py' shows how to use it.
I had to restructure and modify quite a lot of files, but only major changes was made in the qmlearn submodule.

It is hardcoded to predict energies at the moment, but energies can be replaced with any molecular property. Atomic properties is not supported yet.

Tests are on the todo list.

Copy link
Member

@andersx andersx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good good

Copy link
Member

@andersx andersx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(y)

@larsbratholm larsbratholm merged commit 9143138 into qmlcode:develop Sep 10, 2018
@larsbratholm larsbratholm deleted the qmlearn branch September 10, 2018 16:03
zaspel pushed a commit to zaspel/qml that referenced this pull request Jul 29, 2019
* Made base representations

* started CM and data class

* Working on generate routine

* Working basic example

* Mostly hacked the searchcv routines to work

* Implementing atomic gaussian kernel

* working atomic krr

* Restructure and started global slatm

* Slatm

* Started acsf

* stash before merging acsf bugfix

* acsf bugfix cherrypick

* sigma='auto' option added to kernels

* Started fchl

* Working fchl

* Started preprocessing

* Mostly working atom scaler

* Made several attributes private

* Restructured how the data object is passed, to avoid possible memory issues

* Started alchemy in kernels

* Minor change to kernel alchemy

* Working feature trick in kernels

* Cleaned up code

* daily

* Finished examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants