Improve modeler.ReadAccessor buffer handling #88
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modeler.ReadAccessor
now takes a[]byte
as the buffer parameter instead ofany
. It will internally cast that slice to the appropriate type and use it as backing memory when reading the accessor data.This new approach has the advantage of allowing to reuse the same buffer for different accessor types. Previously, the buffer would only be used if the buffer type would match the accessor type.
Additionally, all the other
modeler.Read*
functions have been updated to pass a pooled buffer intomodeler.ReadAccessor
instead of the buffer passed by the caller.