-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Action documentation for Docker image stability and security #1042
Update GitHub Action documentation for Docker image stability and security #1042
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
steps: | ||
- name: PR Agent action step | ||
id: pragent | ||
uses: docker://codiumai/pr-agent@sha256:14165e525678ace7d9b51cda8652c2d74abb4e1d76b57c4a6ccaeba84663cc64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a link to digest, to explain how you found the SHA. It is not trivial
[digest](https://hub.docker.com/layers/codiumai/pr-agent/0.23-github_action/images/sha256-14165e525678ace7d9b51cda8652c2d74abb4e1d76b57c4a6ccaeba84663cc64?context=repo)
... | ||
``` | ||
|
||
For enhanced security, you can also specify the Docker image by its digest: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the "enhanced security".
its a bit confusing. It will not protect you from cyber attacks.
you mean to say that it ensures without a doubt that the docker will be freezed (although in practice the v0... models are freezed anyway)
you can also specify the Docker image by its digest:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean specifying the Docker image digest enhances security because it is effective in preventing supply chain attacks.
If the term "enhanced security" is confusing, would it be clearer to phrase it as "to prevent supply chain attacks"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you know what, its ok. thanks for the PR
Thank you for merging! |
User description
This pull request updates the GitHub Action documentation to improve clarity and enhance security measures.
uses
to show how to use a specific version directly from Docker Hub.ref. #1034
PR Type
Documentation
Description
v2.0
tov0.23
to use an existing Docker image version as a sample.uses
to show how to use a specific version directly from Docker Hub.Changes walkthrough 📝
github.md
Update GitHub Action documentation for Docker image stability and
security
docs/docs/installation/github.md
v2.0
tov0.23
for Docker image version.uses
to demonstrate using a specific version directly fromDocker Hub.
enhanced security.