Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only publish empty code suggestions when configured #1407

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

mrT23
Copy link
Collaborator

@mrT23 mrT23 commented Dec 22, 2024

User description

#1404


PR Type

Bug fix


Description

  • Fixed a bug where the publish_output_no_suggestions configuration was being ignored when publishing empty code suggestions
  • Now, empty code suggestions will only be published when both publish_output and publish_output_no_suggestions are enabled

Changes walkthrough 📝

Relevant files
Bug fix
pr_code_suggestions.py
Fix empty code suggestions publishing logic                           

pr_agent/tools/pr_code_suggestions.py

  • Added condition to check publish_output_no_suggestions config before
    publishing empty code suggestions
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    qodo-merge-pro-for-open-source bot commented Dec 22, 2024

    PR Reviewer Guide 🔍

    (Review updated until commit 31aa460)

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    1404 - Fully compliant

    Compliant requirements:

    • Re-introduces the publish_output_no_suggestions feature by adding the config check in the code
    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🏅 Score: 95
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @mrT23
    Copy link
    Collaborator Author

    mrT23 commented Dec 22, 2024

    /describe

    @mrT23
    Copy link
    Collaborator Author

    mrT23 commented Dec 22, 2024

    /review

    Copy link
    Contributor

    PR Description updated to latest commit (31aa460)

    Copy link
    Contributor

    Persistent review updated to latest commit 31aa460

    @mrT23 mrT23 merged commit a1921d9 into main Dec 22, 2024
    2 checks passed
    @mrT23 mrT23 deleted the tr/publish_output_no_suggestions_fix branch December 22, 2024 07:34
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants