Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generally available gemini-2.0-flash #1539

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Feb 16, 2025

User description

gemini-2.0-flash is now GA. So, it would be good to replace the experimental model of gemini-2.0-flash-exp with it.


PR Type

Enhancement


Description

  • Replaced experimental model gemini-2.0-flash-exp with GA gemini-2.0-flash.

  • Updated model references in pr_agent/algo/__init__.py.


Changes walkthrough 📝

Relevant files
Enhancement
__init__.py
Replace experimental model with GA version                             

pr_agent/algo/init.py

  • Replaced gemini-2.0-flash-exp with gemini-2.0-flash.
  • Updated model references in two locations.
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
    @yu-iskw yu-iskw marked this pull request as ready for review February 16, 2025 23:41
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Learned
    best practice
    Replace hardcoded numeric values with named constants to improve maintainability and readability

    Extract the hardcoded context window size (1048576) into a named constant at the
    module level. This makes it easier to update the value if needed and improves
    code readability by giving semantic meaning to the number.

    pr_agent/algo/init.py [48-52]

    -'vertex_ai/gemini-2.0-flash': 1048576,
    -'gemini/gemini-2.0-flash': 1048576,
    +GEMINI_FLASH_CONTEXT_SIZE = 1048576  # 1M tokens
     
    +# In the dictionary:
    +'vertex_ai/gemini-2.0-flash': GEMINI_FLASH_CONTEXT_SIZE,
    +'gemini/gemini-2.0-flash': GEMINI_FLASH_CONTEXT_SIZE,
    +
    • Apply this suggestion
    Suggestion importance[1-10]: 6
    Low
    • Author self-review: I have reviewed the PR code suggestions, and addressed the relevant ones.

    @mrT23 mrT23 merged commit 5ca6918 into qodo-ai:main Feb 17, 2025
    2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants