[CLEAN] Synthetic Benchmark PR #25189 - Updated activitypub Bluesky sharing enablement flow#243
Open
tomerqodo wants to merge 5 commits intobase_pr_25189_20260121_5311from
Open
[CLEAN] Synthetic Benchmark PR #25189 - Updated activitypub Bluesky sharing enablement flow#243tomerqodo wants to merge 5 commits intobase_pr_25189_20260121_5311from
tomerqodo wants to merge 5 commits intobase_pr_25189_20260121_5311from
Conversation
ref TryGhost/ActivityPub#1377 We updated the backend implementation of the Bluesky sharing enablement process to include a confirmation step in which the client would prompt the backend to check what handle has been assigned to the Bluesky account generated by Bridgy Fed - This circumvents the need to for us to compute the handle manually and potentially getting it wrong if we compute it in a different way to Bridgy Fed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR TryGhost#25189
Type: Clean (correct implementation)
Original PR Title: Updated activitypub Bluesky sharing enablement flow
Original PR Description: ref TryGhost/ActivityPub#1377
We updated the backend implementation of the Bluesky sharing enablement process to include a confirmation step in which the client would prompt the backend to check what handle has been assigned to the Bluesky account generated by Bridgy Fed - This circumvents the need to for us to compute the handle manually and potentially getting it wrong if we compute it in a different way to Bridgy Fed
Note
Switch Bluesky sharing to v2 enable/disable endpoints, add handle confirmation flow with polling, update UI/state, and bump package to 2.0.0.
v2(enable,disable) and addconfirm-handleendpoint.enableBluesky()to no longer return a handle; introduceconfirmBlueskyHandle()returning a confirmed handle or empty string.AccountwithblueskyHandleConfirmedand makeblueskyHandlenullable.apps/activitypub/src/hooks/use-activity-pub-queries.ts):useConfirmBlueskyHandleMutationForUserand cache updater for Bluesky details.{blueskyEnabled, blueskyHandleConfirmed, blueskyHandle}appropriately and invalidate follows.views/Preferences/components/BlueskySharing.tsx):src/api/activitypub.test.ts):v2endpoints; add tests for handle confirmation and null/invalid responses.@tryghost/activitypubversion to2.0.0.Written by Cursor Bugbot for commit c743df5. This will update automatically on new commits. Configure here.
Original PR URL: TryGhost#25189