Skip to content

[CLEAN] Synthetic Benchmark PR #25189 - Updated activitypub Bluesky sharing enablement flow#243

Open
tomerqodo wants to merge 5 commits intobase_pr_25189_20260121_5311from
clean_pr_25189_20260121_5311
Open

[CLEAN] Synthetic Benchmark PR #25189 - Updated activitypub Bluesky sharing enablement flow#243
tomerqodo wants to merge 5 commits intobase_pr_25189_20260121_5311from
clean_pr_25189_20260121_5311

Conversation

@tomerqodo
Copy link

Benchmark PR TryGhost#25189

Type: Clean (correct implementation)

Original PR Title: Updated activitypub Bluesky sharing enablement flow
Original PR Description: ref TryGhost/ActivityPub#1377

We updated the backend implementation of the Bluesky sharing enablement process to include a confirmation step in which the client would prompt the backend to check what handle has been assigned to the Bluesky account generated by Bridgy Fed - This circumvents the need to for us to compute the handle manually and potentially getting it wrong if we compute it in a different way to Bridgy Fed


Note

Switch Bluesky sharing to v2 enable/disable endpoints, add handle confirmation flow with polling, update UI/state, and bump package to 2.0.0.

  • API:
    • Migrate Bluesky endpoints to v2 (enable, disable) and add confirm-handle endpoint.
    • Change enableBluesky() to no longer return a handle; introduce confirmBlueskyHandle() returning a confirmed handle or empty string.
    • Extend Account with blueskyHandleConfirmed and make blueskyHandle nullable.
  • Hooks (apps/activitypub/src/hooks/use-activity-pub-queries.ts):
    • Add useConfirmBlueskyHandleMutationForUser and cache updater for Bluesky details.
    • Update enable/disable mutations to set {blueskyEnabled, blueskyHandleConfirmed, blueskyHandle} appropriately and invalidate follows.
  • UI (views/Preferences/components/BlueskySharing.tsx):
    • Implement enablement confirmation flow with polling, loading states, success/error toasts, and conditional rendering once handle is confirmed.
    • Update disable flow and button states; show link to Bluesky profile when confirmed.
  • Tests (src/api/activitypub.test.ts):
    • Update Bluesky tests for v2 endpoints; add tests for handle confirmation and null/invalid responses.
  • Package:
    • Bump @tryghost/activitypub version to 2.0.0.

Written by Cursor Bugbot for commit c743df5. This will update automatically on new commits. Configure here.

Original PR URL: TryGhost#25189

mike182uk and others added 5 commits January 21, 2026 15:51
ref TryGhost/ActivityPub#1377

We updated the backend implementation of the Bluesky sharing enablement process
to include a confirmation step in which the client would prompt the backend
to check what handle has been assigned to the Bluesky account generated by
Bridgy Fed - This circumvents the need to for us to compute the handle manually
and potentially getting it wrong if we compute it in a different way to Bridgy
Fed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants