[CLEAN] Synthetic Benchmark PR #64455 - Add IOutputCachePolicyProvider to OutputCacheMiddleware and related c…#1
Open
tomerqodo wants to merge 1 commit intobase_pr_64455_20251230_6219from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR dotnet#64455
Type: Clean (correct implementation)
Original PR Title: Add IOutputCachePolicyProvider to OutputCacheMiddleware and related c…
Original PR Description: # Add IOutputCachePolicyProvider for policy validation
Description
This PR implements the API proposal from issue dotnet#52419 to add policy validation capabilities to the OutputCache middleware, following the same pattern as
IAuthorizationPolicyProviderandICorsPolicyProvider.This PR completes and addresses all the feedback from the previous PR dotnet#57362, which was closed due to missing implementations of the API review requirements.
What This PR Adds on Top of dotnet#57362:
This implementation fully addresses all the feedback from @halter73's API review comments:
Fixes dotnet#52419
Original PR URL: dotnet#64455