Skip to content

Comments

[CLEAN] Synthetic Benchmark PR #26301 - feat: integrate BookingHistory with Bookings V3 design#249

Open
bar-qodo wants to merge 1 commit intobase_pr_26301_20260113_2643from
clean_pr_26301_20260113_2643
Open

[CLEAN] Synthetic Benchmark PR #26301 - feat: integrate BookingHistory with Bookings V3 design#249
bar-qodo wants to merge 1 commit intobase_pr_26301_20260113_2643from
clean_pr_26301_20260113_2643

Conversation

@bar-qodo
Copy link

Benchmark PR calcom#26301

Type: Clean (correct implementation)

Original PR Title: feat: integrate BookingHistory with Bookings V3 design
Original PR Description: ## What does this PR do?

Integrates the Booking History feature into the Bookings V3 design by adding an Info/History segmented control in the booking details sheet. This allows users to view booking audit logs directly within the booking details panel instead of navigating to a separate page.

Loom Demo

Key changes:

  • Added new SegmentedControl UI component to @calcom/ui
  • Added Info/History tabs in BookingDetailsSheet (gated by booking-audit feature flag)
  • Moved BookingLogsView to @calcom/features/booking-audit as BookingHistory
  • Added FeaturesRepository.getUserFeaturesStatus() method for efficient batch feature flag checks
  • Added BookingHistoryPage wrapper for standalone page context

Updates since last revision

  • Renamed useBiDirectionalSyncBetweenZustandAndNuqs to useBiDirectionalSyncBetweenStoreAndUrl to avoid using provider names in concrete implementations

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - internal feature flag gated functionality.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Enable the booking-audit feature flag for a test user
  2. Navigate to Bookings page with Bookings V3 enabled
  3. Click on a booking to open the details sheet
  4. Verify the Info/History segmented control appears
  5. Click "History" tab and verify booking audit logs are displayed
  6. Verify the /booking/[uid]/logs page still works with the new BookingHistoryPage component

Without feature flag:

  • Verify the segmented control does NOT appear when booking-audit flag is disabled
  • Verify only the Info content is shown

Human Review Checklist

  • Verify SegmentedControl component renders correctly and is accessible
  • Verify feature flag gating works correctly (tabs hidden when booking-audit disabled)
  • Verify getUserFeaturesStatus handles edge cases (empty slugs array, missing features)
  • Verify the History tab correctly displays booking audit logs
  • Verify bi-directional sync between store and URL works correctly (active segment persists on page refresh)
    Original PR URL: feat: integrate BookingHistory with Bookings V3 design calcom/cal.com#26301

@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CLEAN] Synthetic Benchmark PR #26301 - feat: integrate BookingHistory with Bookings V3 design". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants