Skip to content

Comments

[CLEAN] Synthetic Benchmark PR #26415 - refactor(companion): event type details screen improvements#255

Open
bar-qodo wants to merge 1 commit intobase_pr_26415_20260113_6523from
clean_pr_26415_20260113_6523
Open

[CLEAN] Synthetic Benchmark PR #26415 - refactor(companion): event type details screen improvements#255
bar-qodo wants to merge 1 commit intobase_pr_26415_20260113_6523from
clean_pr_26415_20260113_6523

Conversation

@bar-qodo
Copy link

Benchmark PR calcom#26415

Type: Clean (correct implementation)

Original PR Title: refactor(companion): event type details screen improvements
Original PR Description: ## What does this PR do?

This PR improves the event type details screen using a context menu for iOS and also removes the bottom actions view in favor of adding those features inside the scroll view for a cleaner UI.

Image Demo (if applicable):

image image

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Run the app and navigate to the event type details screen

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by cubic

Refactored the Event Type Detail screen to use an iOS header menu for tab switching and registered the new route. This streamlines navigation, cleans up the UI, and improves content layout.

  • UI Improvements

    • Added a transparent iOS header with a tab menu and Save button.
    • Converted the bottom action bar into an in-content action card with preview, copy link, and delete.
    • Enabled automatic content inset adjustment for smoother scrolling.
  • Refactors

    • Moved EventTypeDetail to its own file and registered the "event-type-detail" route; kept platform-specific header behavior.

Written for commit 98e7b25. Summary will update on new commits.

Original PR URL: calcom#26415

@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CLEAN] Synthetic Benchmark PR #26415 - refactor(companion): event type details screen improvements". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants