Skip to content

Comments

[CORRUPTED] Synthetic Benchmark PR #26061 - fix: enable DI for FeatureOptInService#696

Closed
tomerqodo wants to merge 2 commits intobase_pr_26061_20260121_5907from
corrupted_pr_26061_20260121_5907
Closed

[CORRUPTED] Synthetic Benchmark PR #26061 - fix: enable DI for FeatureOptInService#696
tomerqodo wants to merge 2 commits intobase_pr_26061_20260121_5907from
corrupted_pr_26061_20260121_5907

Conversation

@tomerqodo
Copy link

Benchmark PR calcom#26061

Type: Corrupted (contains bugs)

Original PR Title: fix: enable DI for FeatureOptInService
Original PR Description: ## What does this PR do?

This PR adds DI support for FeatureOptInService and FeaturesRepository.

But we're still using FeaturesRepository directly across the project, and I will fix it in a separate PR.

Updates since last revision

  • Renamed FeatureOptInServiceInterface.ts to IFeatureOptInService.ts to follow the codebase convention of using I prefix for interface files
  • Renamed the interface from FeatureOptInServiceInterface to IFeatureOptInService
  • Updated all references to use the new naming convention

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Run type checks: yarn type-check:ci --force
  2. Run tests: TZ=UTC yarn test
  3. Verify the DI containers correctly resolve FeatureOptInService and FeaturesRepository

Summary by cubic

Enables DI for FeatureOptInService and FeaturesRepository across the app. Replaces direct instantiation and Prisma usage with moduleLoader-based containers and updates router/tests to resolve the service via DI.

  • Refactors
    • Added DI modules/containers and helpers for FeatureOptInService and FeaturesRepository; introduced feature-specific DI tokens and merged them into DI_TOKENS.
    • Replaced the deprecated Features module with FeaturesRepository module and updated related imports.
    • Added IFeatureOptInService and implemented it in the service.
    • Updated TRPC viewer.featureOptIn router and integration tests to use DI.

Written for commit 259569f. Summary will update on new commits.


Link to Devin run: https://app.devin.ai/sessions/de393c9ea2b8412587a8c4ca8cb2631d
Requested by: @eunjae-lee (eunjae@cal.com)
Original PR URL: calcom#26061

@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CORRUPTED] Synthetic Benchmark PR #26061 - fix: enable DI for FeatureOptInService". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions
Copy link

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@github-actions github-actions bot added the Stale label Jan 30, 2026
@github-actions
Copy link

This PR has been closed due to inactivity. Please feel free to reopen it if you'd like to continue the work.

@github-actions github-actions bot closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant