[CORRUPTED] Synthetic Benchmark PR #26061 - fix: enable DI for FeatureOptInService#696
Closed
tomerqodo wants to merge 2 commits intobase_pr_26061_20260121_5907from
Closed
[CORRUPTED] Synthetic Benchmark PR #26061 - fix: enable DI for FeatureOptInService#696tomerqodo wants to merge 2 commits intobase_pr_26061_20260121_5907from
tomerqodo wants to merge 2 commits intobase_pr_26061_20260121_5907from
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
This was referenced Jan 21, 2026
This was referenced Jan 26, 2026
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
|
This PR has been closed due to inactivity. Please feel free to reopen it if you'd like to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR calcom#26061
Type: Corrupted (contains bugs)
Original PR Title: fix: enable DI for FeatureOptInService
Original PR Description: ## What does this PR do?
This PR adds DI support for FeatureOptInService and FeaturesRepository.
But we're still using FeaturesRepository directly across the project, and I will fix it in a separate PR.
Updates since last revision
FeatureOptInServiceInterface.tstoIFeatureOptInService.tsto follow the codebase convention of usingIprefix for interface filesFeatureOptInServiceInterfacetoIFeatureOptInServiceMandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarn type-check:ci --forceTZ=UTC yarn testSummary by cubic
Enables DI for FeatureOptInService and FeaturesRepository across the app. Replaces direct instantiation and Prisma usage with moduleLoader-based containers and updates router/tests to resolve the service via DI.
Written for commit 259569f. Summary will update on new commits.
Link to Devin run: https://app.devin.ai/sessions/de393c9ea2b8412587a8c4ca8cb2631d
Requested by: @eunjae-lee (eunjae@cal.com)
Original PR URL: calcom#26061