feat: Add conversation variable persistence layer by tomerqodo · Pull Request #1 · qodo-benchmark/dify-combined-coderabbit

tomerqodo · 2026-01-16T19:30:31Z

… factory to pass the ConversationVariableUpdater factory (the only non-VariablePool dependency), plus a unit test to verify the injection path. - `api/core/workflow/nodes/variable_assigner/v2/node.py` adds a kw-only `conv_var_updater_factory` dependency (defaulting to `conversation_variable_updater_factory`) and stores it for use in `_run`. - `api/core/workflow/nodes/node_factory.py` now injects the factory when creating VariableAssigner v2 nodes. - `api/tests/unit_tests/core/workflow/nodes/variable_assigner/v2/test_variable_assigner_v2.py` adds a test asserting the factory is injected. Tests not run. Next steps (optional): 1) `make lint` 2) `make type-check` 3) `uv run --project api --dev dev/pytest/pytest_unit_tests.sh`

…ructor args. - `api/core/workflow/nodes/node_factory.py` now directly instantiates `VariableAssignerNode` with the injected dependency, and uses a direct call for all other nodes. No tests run.

Add a new command for GraphEngine to update a group of variables. This command takes a group of variable selectors and new values. When the engine receives the command, it will update the corresponding variable in the variable pool. If it does not exist, it will add it; if it does, it will overwrite it. Both behaviors should be treated the same and do not need to be distinguished.

…be-kanban 0941477f) Create a new persistence layer for the Graph Engine. This layer receives a ConversationVariableUpdater upon initialization, which is used to persist the received ConversationVariables to the database. It can retrieve the currently processing ConversationId from the engine's variable pool. It captures the successful execution event of each node and determines whether the type of this node is VariableAssigner(v1 and v2). If so, it retrieves the variable name and value that need to be updated from the node's outputs. This layer is only used in the Advanced Chat. It should be placed outside of Core.Workflow package.

…rs/conversation_variable_persist_layer.py` to satisfy SIM118 - chore(lint): run `make lint` (passes; warnings about missing RECORD during venv package uninstall) - chore(type-check): run `make type-check` (fails: 1275 errors for missing type stubs like `opentelemetry`, `click`, `sqlalchemy`, `flask`, `pydantic`, `pydantic_settings`)

…tType validation and casting - test(graph-engine): update VariableUpdate usages to include value_type in command tests

… drop common_helpers usage - refactor(variable-assigner-v2): inline updated variable payload and drop common_helpers usage Tests not run.

…n and remove value type validation - test(graph-engine): update UpdateVariablesCommand tests to pass concrete Variable instances - fix(graph-engine): align VariableUpdate values with selector before adding to VariablePool Tests not run.

…e handling for v1/v2 process_data - refactor(app-layer): read updated variables from process_data in conversation variable persistence layer - test(app-layer): adapt persistence layer tests to use common_helpers updated-variable payloads Tests not run.

…nce reads from process_data

…fter venv changes) - chore(type-check): run `make type-check` (fails: 1275 missing type stubs across dependencies) Details: - `make lint` fails with `ModuleNotFoundError: No module named 'dotenv_linter.cli'`. - `make type-check` fails with missing stubs for `opentelemetry`, `click`, `sqlalchemy`, `flask`, `pydantic`, `pydantic_settings`, etc.

…ableUnion and remove value type validation" This reverts commit 5ebc87a.

…h SegmentType validation and casting" This reverts commit 3edd525.

This reverts commit 67007f6.

…y out of core.workflow into `api/services/conversation_variable_updater.py` - refactor(app): update advanced chat app runner and conversation service to import the new updater factory Tests not run.

…-linter module missing) - chore(type-check): run `make type-check` (fails: 1275 missing type stubs) Details: - `make lint` reports: `No matches for ignored import core.workflow.nodes.variable_assigner.common.impl -> extensions.ext_database` and ends with `ModuleNotFoundError: No module named 'dotenv_linter.cli'`. - `make type-check` fails with missing type stubs for `opentelemetry`, `click`, `sqlalchemy`, `flask`, `pydantic`, `pydantic_settings`, etc.

…impl import in `api/.importlinter`

… error

coderabbitai · 2026-01-16T19:30:38Z

Warning

Rate limit exceeded

@tomerqodo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e3e19c4 and 84196e6.

📒 Files selected for processing (15)

api/.importlinter
api/core/app/apps/advanced_chat/app_runner.py
api/core/app/layers/conversation_variable_persist_layer.py
api/core/workflow/nodes/node_factory.py
api/core/workflow/nodes/variable_assigner/common/impl.py
api/core/workflow/nodes/variable_assigner/v1/node.py
api/core/workflow/nodes/variable_assigner/v2/node.py
api/core/workflow/runtime/graph_runtime_state_protocol.py
api/core/workflow/runtime/read_only_wrappers.py
api/services/conversation_service.py
api/services/conversation_variable_updater.py
api/tests/unit_tests/core/app/layers/test_conversation_variable_persist_layer.py
api/tests/unit_tests/core/app/layers/test_pause_state_persist_layer.py
api/tests/unit_tests/core/workflow/nodes/variable_assigner/v1/test_variable_assigner_v1.py
api/tests/unit_tests/core/workflow/nodes/variable_assigner/v2/test_variable_assigner_v2.py

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tomerqodo · 2026-01-17T01:25:23Z

@coderabbitai review

coderabbitai · 2026-01-17T01:25:28Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

tomerqodo · 2026-01-17T01:28:10Z

@coderabbitai review

coderabbitai · 2026-01-17T01:28:15Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

tomerqodo · 2026-01-17T01:29:44Z

@coderabbitai review

coderabbitai · 2026-01-17T01:29:49Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

laipz8200 and others added 21 commits January 5, 2026 13:19

Updated to avoid the dict path and let the type checker enforce const…

0fd225a

…ructor args. - `api/core/workflow/nodes/node_factory.py` now directly instantiates `VariableAssignerNode` with the injected dependency, and uses a direct call for all other nodes. No tests run.

- feat(graph-engine): enforce variable update value types with Segmen…

3edd525

…tType validation and casting - test(graph-engine): update VariableUpdate usages to include value_type in command tests

- refactor(variable-assigner-v1): inline updated variable payload and…

638b0ef

… drop common_helpers usage - refactor(variable-assigner-v2): inline updated variable payload and drop common_helpers usage Tests not run.

- refactor(variable-assigner): drop updated outputs now that persiste…

8505033

…nce reads from process_data

Revert "- refactor(graph-engine): switch VariableUpdate.value to Vari…

99509eb

…ableUnion and remove value type validation" This reverts commit 5ebc87a.

Revert "- feat(graph-engine): enforce variable update value types wit…

2b044dd

…h SegmentType validation and casting" This reverts commit 3edd525.

Revert "A new command for updating variables. (vibe-kanban 00377ffe)"

2831694

This reverts commit 67007f6.

- refactor(services): move ConversationVariableUpdaterImpl and factor…

b083fa2

…y out of core.workflow into `api/services/conversation_variable_updater.py` - refactor(app): update advanced chat app runner and conversation service to import the new updater factory Tests not run.

- chore(import-linter): remove obsolete ignore for variable_assigner …

1192648

…impl import in `api/.importlinter`

fix(core): guard conversation variable flush when no updates

7c30854

fix(core): use system variable conversation_id and add custom updater…

09b7aed

… error

fix(services): use Exception for conversation variable not found

7b19f20

Apply changes for benchmark PR

84196e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add conversation variable persistence layer #1

tomerqodo commented Jan 16, 2026

Uh oh!

coderabbitai bot commented Jan 16, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

tomerqodo commented Jan 17, 2026

Uh oh!

coderabbitai bot commented Jan 17, 2026

Uh oh!

tomerqodo commented Jan 17, 2026

Uh oh!

coderabbitai bot commented Jan 17, 2026

Uh oh!

tomerqodo commented Jan 17, 2026

Uh oh!

coderabbitai bot commented Jan 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

tomerqodo commented Jan 16, 2026

Uh oh!

coderabbitai bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

tomerqodo commented Jan 17, 2026

Uh oh!

coderabbitai bot commented Jan 17, 2026

Uh oh!

tomerqodo commented Jan 17, 2026

Uh oh!

coderabbitai bot commented Jan 17, 2026

Uh oh!

tomerqodo commented Jan 17, 2026

Uh oh!

coderabbitai bot commented Jan 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

coderabbitai bot commented Jan 16, 2026 •

edited

Loading