[CORRUPTED] Synthetic Benchmark PR #30156 - fix: remove hardcoded 48-character limit from text inputs#321
Open
ofir-frd wants to merge 16 commits intobase_pr_30156_20260120_6849from
Open
Conversation
Remove the DEFAULT_VALUE_MAX_LEN (48) fallback from text input components. When max_length is not configured, inputs should have no character limit. This fixes an issue where text inputs in workflow and chatflow were always limited to 48 characters even when the max_length setting was removed. The fix: - Removes DEFAULT_VALUE_MAX_LEN fallback from Input maxLength prop - Only applies maxLength when max_length is explicitly configured - Adds tests to verify maxLength behavior fixes langgenius#26940 Signed-off-by: majiayu000 <1835304752@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR langgenius#30156
Type: Corrupted (contains bugs)
Original PR Title: fix: remove hardcoded 48-character limit from text inputs
Original PR Description: ## Summary
DEFAULT_VALUE_MAX_LEN(48 characters) fallback from text input componentsmax_lengthis not configured, inputs now have no character limit as expectedmaxLengthwhen explicitly configured by the userTest plan
fixes langgenius#26940
Original PR URL: langgenius#30156
Compliance Violation