[CLEAN] Synthetic Benchmark PR #30251 - fix: workflow incorrectly marked as completed while nodes are still executing#440
Open
tomerqodo wants to merge 3 commits intobase_pr_30251_20260121_6712from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR langgenius#30251
Type: Clean (correct implementation)
Original PR Title: fix: workflow incorrectly marked as completed while nodes are still executing
Original PR Description:
Important
Fixes #<issue number>.Fixes langgenius#30195
Fixes langgenius#29316
Summary
When the last upstream node is skipped, the downstream node is added only to
_ready_queueand not to_executing_nodes.After the worker thread consumes
_ready_queue, both_ready_queueand_executing_nodesbecome empty.As a result, the
_dispatcher_loopexits the while loop incorrectly.Can reproduct use thie DSL: CheckSkip.yml
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsOriginal PR URL: langgenius#30251