Skip to content

[CORRUPTED] Synthetic Benchmark PR #19951 - feat(ui-v2): improve task run details page parity with Vue#573

Open
tomerqodo wants to merge 5 commits intobase_pr_19951_20260121_4505from
corrupted_pr_19951_20260121_4505
Open

[CORRUPTED] Synthetic Benchmark PR #19951 - feat(ui-v2): improve task run details page parity with Vue#573
tomerqodo wants to merge 5 commits intobase_pr_19951_20260121_4505from
corrupted_pr_19951_20260121_4505

Conversation

@tomerqodo
Copy link

Benchmark PR PrefectHQ#19951

Type: Corrupted (contains bugs)

Original PR Title: feat(ui-v2): improve task run details page parity with Vue
Original PR Description: Improves the task run details page in the React UI to achieve better parity with the legacy Vue implementation. This was done by inspecting both codebases and comparing the implementations.

Changes

Task Inputs tab: Added copy button using the existing copy prop on JsonInput

Browser integration:

  • Added usePageTitle hook to set browser tab title to "Task Run: {name}"
  • Created new useStateFavicon hook that changes the browser favicon based on task run state
  • Added state-specific SVG icons (cancelled, completed, crashed, failed, pending, running, scheduled)

Navigation: Fixed breadcrumb to link to /runs?tab=task-runs instead of just /runs

Details sidebar: Changed from hiding empty fields to consistently showing "None" for:

  • Flow Run, Start Time, Duration, Run Count, Estimated Run Time, Created, Last Updated
  • Cache Key, Cache Expiration, Dynamic Key
  • Retry Delay, Retry Jitter Factor

Updates since last revision

  • Renamed useFavicon to useStateFavicon to better communicate that the hook only handles updating the favicon to a state icon
  • Added comprehensive test coverage for useStateFavicon hook (10 test cases)

Local Testing

Verified all changes work correctly:

Task run details page with all fields showing "None" for empty values:
Task run details

Task Inputs tab with copy button:
Task Inputs with copy

Copy button showing toast notification:
Copy toast

Breadcrumb navigation to Task Runs tab:
Breadcrumb navigation

Screen recording of testing:
Testing recording

View original video (rec-bd2233e5f0354d5bbc9431c21f5bac44-edited.mp4)

Review Checklist for Humans

  • Verify favicon element IDs (favicon-16, favicon-32, favicon-16-dark, favicon-32-dark) exist in index.html
  • Note: SVG icons only added for cancelled, completed, crashed, failed, pending, running, scheduled states - CANCELLING and PAUSED states will not update favicon
  • Visual verification that the task run details page displays correctly
  • Test that favicon changes when viewing task runs in different states
  • Verify breadcrumb navigation goes to the correct tab

Link to Devin run: https://app.devin.ai/sessions/c3243ce35f2d4ea892c5a297a3c8da55
Requested by: alex.s@prefect.io (@desertaxle)

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.
    Original PR URL: feat(ui-v2): improve task run details page parity with Vue PrefectHQ/prefect#19951

devin-ai-integration bot and others added 5 commits January 21, 2026 15:47
- Add copy button to Task Inputs tab using JsonInput copy prop
- Add usePageTitle hook to set browser tab title based on task run name
- Add useFavicon hook to change favicon based on task run state
- Add state-specific SVG icons for favicon (cancelled, completed, crashed, failed, pending, running, scheduled)
- Fix breadcrumb to link to /runs?tab=task-runs instead of just /runs
- Show all detail fields consistently with 'None' when empty instead of hiding them
- Add Cache Key, Cache Expiration, Retry Delay, and Retry Jitter Factor fields to always display

Co-Authored-By: alex.s@prefect.io <ajstreed1@gmail.com>
Co-Authored-By: alex.s@prefect.io <ajstreed1@gmail.com>
Co-Authored-By: alex.s@prefect.io <ajstreed1@gmail.com>
Co-Authored-By: alex.s@prefect.io <ajstreed1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant