[CLEAN] Synthetic Benchmark PR #14227 - Fix HINCRBYFLOAT removes field expiration on replica#103
Open
tomerqodo wants to merge 4 commits intobase_pr_14227_20260121_4919from
Open
[CLEAN] Synthetic Benchmark PR #14227 - Fix HINCRBYFLOAT removes field expiration on replica#103tomerqodo wants to merge 4 commits intobase_pr_14227_20260121_4919from
tomerqodo wants to merge 4 commits intobase_pr_14227_20260121_4919from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR redis#14227
Type: Clean (correct implementation)
Original PR Title: Fix HINCRBYFLOAT removes field expiration on replica
Original PR Description: Fixes redis#14218
Before, we replicate HINCRBYFLOAT as an HSET command with the final value in order to make sure that differences in float precision or formatting will not create differences in replicas or after an AOF restart.
However, on the replica side, if the field has an expiration time, HSET will remove it, even though the master retains it. This leads to inconsistencies between the master and the replica.
For Redis 8.0 and above, PR #14224 has fixed this issue. However, Redis 7.4 does not support the HSETEX command. To address this, HINCRBYFLOAT will be replicated as a simple HSET if no expiration is set. If an expiration is specified, it will be replicated as a MULTI/EXEC containing HSET and HPEXPIREAT commands.
Original PR URL: redis#14227