Add test_bases from QuantumOpticsBase and reorganize a bit #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirakyle
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
===========================================
+ Coverage 17.08% 34.25% +17.16%
===========================================
Files 12 12
Lines 398 400 +2
===========================================
+ Hits 68 137 +69
+ Misses 330 263 -67 ☔ View full report in Codecov by Sentry. |
akirakyle
force-pushed
the
reorganize
branch
3 times, most recently
from
ab297e7 to
791017c
Compare
|
could you also bump the JET ignore count to 3. It seems it is the case on master as well. |
Krastanov
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Sorry for the delay in getting this reviewed!
This type of reordering is usually to be avoided for two reasons:
- It took me a lot of time to review the changes as moving this around leads to a ton of lines marked as modified (git diff is not very good about just showing moves).
- Using git blame in the future will be much more difficult.
With this in mind, what are the advantages of the reordering that make it worth to pay the price?
| """ | ||
| Abstract base class for all specialized bases. | ||
|
|
||
| The Basis class is meant to specify a basis of the Hilbert space of the |
There was a problem hiding this comment.
The Basis class is meant to specify the Hilbert space of the
To avoid the confusion about basis vs space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of more significant changes to the basis interface and abstract types being discussed across #12 #25 #26 #27 #33 #34 #35 #36 this PR adds the
test_basesfromQuantumOpticsBase, moves all theshowmethods to their own file, and does a little more reorganization. No logic should be affected with this change.