Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place Node struct internals under Arc #724

Closed
ikopylov opened this issue Jan 9, 2023 · 0 comments · Fixed by #775
Closed

Place Node struct internals under Arc #724

ikopylov opened this issue Jan 9, 2023 · 0 comments · Fixed by #775
Assignees
@ikopylov
Labels
improvement

Comments

@ikopylov
Copy link
Member

ikopylov commented Jan 9, 2023

Node cloned many times and it consists of 2 string fields. It would be good to have Arc to reduce copy overhead

https://github.com/qoollo/bob/blob/master/bob-common/src/node.rs#L19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikopylov ikopylov

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[774] BobClient reduce clone overhead qoollo/bob
1 participant
@ikopylov