[774] BobClient reduce clone overhead #775

ikopylov · 2023-02-19T19:59:42Z

Closes #774
Closes #724
Closes #593

Covers required changes from #653

…-clone

bob-common/src/configs/cluster.rs

bob-common/src/name_types.rs

…-clone # Conflicts: # CHANGELOG.md # bob/src/lib.rs

…`DiskName`

bob-common/src/bob_client.rs

bob-common/src/configs/cluster.rs

bob-common/src/configs/cluster_tests.rs

bob-common/src/configs/cluster.rs

bob-common/src/configs/node.rs

bob-common/src/core_types.rs

bob-common/src/name_types.rs

…-clone # Conflicts: # CHANGELOG.md # bob-backend/src/pearl/disk_controller.rs # bob-backend/src/pearl/group.rs # bob-backend/src/pearl/settings.rs

…ization code)

idruzhitskiy

LGTM

ikopylov added 30 commits February 19, 2023 20:56

[774] BobClient reduce clone overhead

0af16d9

[774] Fix build

45acb3e

[774] Fix build

7dd43bc

[774] Fix build warnings

9d75cc2

[774] Remove inner data struct for BobClient

2f1644d

[774] Detect all places where node is clonned

0c5c67b

[774] Trace node clones

c86f54a

[774] Add NodeName struct, wrap Node internals into Arc

578b9c4

[774] Fix build

7e9cee0

[774] Build fixes

4e841f8

[774] Fix build errors

92562a7

[774] Config validation code refactoring

20aa7e9

[774] Better vdisk ids validation

e093329

[774] VDiskMap initialization refactoring

9c81e3a

[774] Fix validation error conversion

7e018c1

[774] Build fix

76f2795

[774] Build fix

e3a953b

[774] Build fix

e182e49

[774] NodeName proper comparison

22f0af3

[774] Fix build

9d1c2bc

[774] Fix build

6396144

[774] Use NodeName everywhere

bdca0c6

[774] Fix build

cb8b3be

[774] Fix build

229e44b

[774] Fix build

cca1d2a

[774] Fix build

5163c02

[774] Fix build

c181186

[774] Fix build

325d5bd

[774] Fix build

ab2b43e

[774] Move operation options into separate file

83424d8

ikopylov added 10 commits April 6, 2023 23:08

[774] Build fix

a5774e5

[774] Build fix

6d6da39

[774] Build fix

67bfb58

[774] Fix build

280baa2

[774] Build fix

6a695bc

[774] Build fix

e60e4eb

[774] Tests build fix

300ef5d

[774] Build fix

62a95e9

Merge branch 'master' into 774-reduce-node-and-bob-client-overhead-on…

7226b10

…-clone

[774] Update Changelog.md

fb1094a

ikopylov marked this pull request as ready for review April 7, 2023 00:03

ikopylov requested a review from idruzhitskiy May 10, 2023 12:45

ikopylov added the required for release label May 11, 2023

idruzhitskiy reviewed May 12, 2023

View reviewed changes

bob-common/src/configs/cluster.rs Outdated Show resolved Hide resolved

bob-common/src/name_types.rs Outdated Show resolved Hide resolved

ikopylov added 8 commits May 13, 2023 16:12

Merge branch 'master' into 774-reduce-node-and-bob-client-overhead-on…

96ba967

…-clone # Conflicts: # CHANGELOG.md # bob/src/lib.rs

[774] Fix build

5d80acc

[774] Replace ref with deref in comparison operations

223cdb4

[774] Fix build

738a20f

[774] Fix build

a6cb385

[774] Print validation error only on the top level

1897a04

[774] Declare generic Name type instead of separate NodeName and …

92dbf3d

…`DiskName`

[774] Fix test

07da304

idruzhitskiy reviewed May 15, 2023

View reviewed changes

ikopylov added 5 commits May 16, 2023 21:00

Merge branch 'master' into 774-reduce-node-and-bob-client-overhead-on…

9140fd0

…-clone # Conflicts: # CHANGELOG.md # bob-backend/src/pearl/disk_controller.rs # bob-backend/src/pearl/group.rs # bob-backend/src/pearl/settings.rs

[774] Remove allow(dead_code) from BobClient

07548da

[774] Remove unneeded escape before ' symbol

8953d06

[774] Remove unneeded must_use attributes

3461dbd

[774] Move ArcStrVisitor to the bottom of the file (close to deserial…

f8b291b

…ization code)

idruzhitskiy approved these changes May 17, 2023

View reviewed changes

ikopylov merged commit 65b6727 into master May 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[774] BobClient reduce clone overhead #775

[774] BobClient reduce clone overhead #775

ikopylov commented Feb 19, 2023 •

edited

Loading

idruzhitskiy left a comment

[774] BobClient reduce clone overhead #775

[774] BobClient reduce clone overhead #775

Conversation

ikopylov commented Feb 19, 2023 • edited Loading

idruzhitskiy left a comment

Choose a reason for hiding this comment

ikopylov commented Feb 19, 2023 •

edited

Loading