Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

296 fix benchmark build errors #297

Merged
merged 5 commits into from
Dec 18, 2023
Merged

296 fix benchmark build errors #297

merged 5 commits into from
Dec 18, 2023

Conversation

archeoss
Copy link
Contributor

Resolves #296

@archeoss archeoss requested a review from ikopylov October 31, 2023 17:50
@archeoss archeoss linked an issue Oct 31, 2023 that may be closed by this pull request
Fix benchmark build errors #296
Closed
ikopylov
ikopylov reviewed Dec 14, 2023
View reviewed changes
src/benchmark/bin.rs Outdated Show resolved Hide resolved
@ikopylov
Copy link
Member

ikopylov commented Dec 14, 2023 •
edited
Loading

Please, add to build-linux job (https://github.com/qoollo/pearl/blob/master/.github/workflows/build.yml#L10) a new step, that builds benchmark (--features benchmark)

@archeoss
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@archeoss archeoss force-pushed the 296-fix-benchmark-build-errors branch from dd2a33f to cd4525e Compare December 16, 2023 12:09
@archeoss archeoss force-pushed the 296-fix-benchmark-build-errors branch from cd4525e to b07b25b Compare December 16, 2023 12:12
@archeoss archeoss requested a review from ikopylov December 16, 2023 12:14
@ikopylov
Copy link
Member

I don't see the benchmark compilation in the build logs (https://github.com/qoollo/pearl/actions/runs/7231822100/job/19705418934?pr=297). Please check whether the benchmark is built

@archeoss
Copy link
Contributor Author

@ikopylov It's definitely builds: https://github.com/qoollo/pearl/actions/runs/7245092090/job/19734481484?pr=297

@archeoss archeoss force-pushed the 296-fix-benchmark-build-errors branch from 97ab21c to b07b25b Compare December 18, 2023 07:52
ikopylov
ikopylov approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@ikopylov ikopylov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikopylov ikopylov merged commit 9178f38 into master Dec 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikopylov ikopylov ikopylov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix benchmark build errors
2 participants
@archeoss @ikopylov