host & item-names filtering added #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziktorin
reviewed
Nov 28, 2022
README.md
Outdated
Comment on lines
23
to
36
| metrics: | ||
| - key: 'local.metric[uwsgi,workers,*,*]' | ||
| name: 'uwsgi_workers' | ||
| labels: | ||
| app: $1 | ||
| status: $2 | ||
| reject: | ||
| - 'total' | ||
| hosts: | ||
| - name.of.host.1 | ||
| - name.of.host.2 | ||
| item_names: | ||
| - '*item.name.substr.1*' | ||
| - '*item.name.substr.2*' |
There was a problem hiding this comment.
type: parameter should be added to example
Ziktorin
reviewed
Nov 28, 2022
HISTORY.rst
Outdated
Comment on lines
2
to
12
| History | ||
| ======= | ||
|
|
||
| 1.0.3 (2022-11-28) | ||
| ------------------ | ||
|
|
||
| * Add zabbix filtering by hosts and item names | ||
|
|
||
| 1.0.2 (2017-02-25) | ||
| ------------------ | ||
|
|
There was a problem hiding this comment.
Could also be changed to markdown, since README.rst was.
Ziktorin
reviewed
Nov 28, 2022
Comment on lines
1
to
4
| Contributors | ||
| ------------ | ||
|
|
||
| * Ilya Baryshev <coagulant@mybook.ru> | ||
| * Kazakov Kirill <kirill.kazakov@qoollo.com> |
There was a problem hiding this comment.
Could also be changed to markdown, since README.rst was.
There was a problem hiding this comment.
Also, if to be converted to .md, it is necessary to change corresponding file names in setup.py
Ziktorin
reviewed
Nov 28, 2022
zabbix_exporter/commands.py
Outdated
| - name.of.host.2 | ||
| item_names: | ||
| - '*item.name.substr.1*' | ||
| - '*item.name.substr.2*' |
There was a problem hiding this comment.
Probably should be the same config as in README.md
Ziktorin
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.