This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
Added Marker to JSON layout. #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Roig <daniel.roig@seb.se>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been scouring the Internet for clues on how to do it with Logback, but ultimately decided to fix this at the source.
I've tried solving my problem by implementing a class that inherits from
ch.qos.logback.contrib.json.classic.JsonLayout, but I lost control on where to put the Marker field since it internally uses aLinkedHashMapso it wound up at the end, which looks a bit weird. My implementation worked, but I figured others might benefit from this functionality, so that's why I created this PR. I've tried to put the Marker field where I thought it made sense (after the log level), but you can obviously change this at your discretion.Hopefully, you'll find it worthwhile to create a new release with this.
Thanks for maintaining Logback, it's usually my go-to logging implementation.