Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up coh_tmm in tmm_core_vec; introduced versions with cpu and gpu parallelization #271

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

arsonwong
Copy link

s and p polarization, 10000 wavelength x angles, 6 layers, calculate coh_tmm:
before speed increase: 4.178s
after speed increase: 2.399s
after speed increase, non-detailed mode: 1.948s
CPU parallelization with 24 cores
CPU parallelization: 0.844s
CPU parallelization, non-detailed mode: 0.719s
GPU parallelization with NVIDIA GeForce RTX 4060
GPU parallelization: 0.296s
GPU parallelization, non-detailed mode: 0.118s

@phoebe-p
Copy link
Member

phoebe-p commented May 7, 2024

sorry for my lack of input on this. I was wondering, for the parallelisation, what do you think the best way to incorporate this would be? I guess there are now three options: no parallelisation (i.e. just the old implementation), GPU parallelisation, or CPU parallelisation. Then there's the detailed vs. non-detailed mode. The user should be able to choose which one they want to use, but it would be better not to have three different files tmm_core_vec files, since most of the content is the same anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants