Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 28 Part 2: Dev Features #35

Merged
merged 7 commits into from
Oct 8, 2022
Merged

Update 28 Part 2: Dev Features #35

merged 7 commits into from
Oct 8, 2022

Conversation

hifocus
Copy link
Collaborator

@hifocus hifocus commented Oct 8, 2022

Merger had long been a single-page HTML application. Since Update 26, the minification of the HTML file is supported via html-minifier. However, the minification achieved in this way is often bulk and careless.

The original solution would be a webpack implementation. However, as the JavaScript in this project is not modular, it's thought an implementation of such would have minimal practical meaning. As a part of Update 28, this pull request emphsises our developer experiences. Now, all the html, js and css files are configured to be minified via a gulpjs implementation.

As jsDelivr loses its ICP license and therefore unable to provide ideal loading speed for visitors from Mainland China, a part of Update 27.1 was to remove support for jsDelivr. With this update, we have some good news: merger has been accepted by cdnjs, and visitors in China are again able to enjoy a speedy loading experience through cdnjs's many mirrors in China.

This Pull Request will form the seond half of v0.28.0-rc. Update 28 RC would be a preview version for a short amount of time, allowing final reivews and configurations to be done.

We hope you will enjoy this update that will bring you and your users drastically enhanced experiences.

Changes

  • 2ece0f3 Rename/remove minified files; at this stage, minified files will no longer rely on particular Code Editors' feature set to be generated. They are now generatable through gulp compile.
  • 472476e, 545b25c, 6a53fa3 and e3fac47 Enable complete gulpjs support
    • npm i
    • npm run compile
    • npm run build - the build will be at /build directory
  • 0f5dfaa After some considerations, the placeholder avatar, considering it's rare practicality, will be loaded remotely on-demand, reversing 088a72c

@netlify
Copy link

netlify bot commented Oct 8, 2022

Deploy Preview for merger-demo ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/merger-demo/deploys/6341bf9aa568737610946010
😎 Deploy Preview https://deploy-preview-35--merger-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 8, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e8125b8
Status: ✅  Deploy successful!
Preview URL: https://5f673bc5.merger.pages.dev
Branch Preview URL: https://update-28-dev-features.merger.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant