feat(dataset.Body): rename Data fields to Body #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a bunch of discussion, we've decided to rename "Data" to "Body", our logic is outlined here: qri-io/qri#422. Basically it's just a rename, but it renames a required field. This'll break all sorts of stuff, but considering we're still _very_ early days, I'd rather get it merged now. To me this dataset-as-html-page metaphor is worth a breaking change, so let's make one. BREAKING CHANGE: dataset.DataPath is renamed to dataset.BodyPath.
ghost
added
the
|
@ramfox if after an initial look you're good with this I'll push a fix to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bunch of discussion, we've decided to rename "Data" to "Body", our logic is outlined here: qri-io/qri#422. Basically it's just a rename, but it renames a required field. This'll break all sorts of stuff, but considering we're still very early days, I'd rather get it merged now.
To me this dataset-as-html-page metaphor is worth a breaking change, so let's make one.
BREAKING CHANGE: dataset.DataPath is renamed to dataset.BodyPath.