Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dataset): Dataset has transient field NumVersions #177

Merged
merged 2 commits into from
Feb 25, 2019
Merged

fix(dataset): Dataset has transient field NumVersions #177

merged 2 commits into from
Feb 25, 2019

Conversation

dustmop
Copy link
Collaborator

@dustmop dustmop commented Feb 25, 2019

No description provided.

@ghost ghost assigned dustmop Feb 25, 2019
@ghost ghost added the in progress label Feb 25, 2019
@dustmop dustmop mentioned this pull request Feb 25, 2019
Merged
@dustmop dustmop requested a review from b5 February 25, 2019 19:46
b5
b5 requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@b5 b5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also add a set-to-zero for NumVersions in dataset.DropTransientValues(), which is in dataset.go

@b5 b5 self-requested a review February 25, 2019 21:07
b5
b5 approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@b5 b5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delightful.

@dustmop dustmop merged commit bdf0bb8 into master Feb 25, 2019
@ghost ghost removed the in progress label Feb 25, 2019
@dustmop dustmop deleted the num-versions branch February 25, 2019 21:18
@dustmop dustmop mentioned this pull request Sep 2, 2021
Merged
@ramfox ramfox mentioned this pull request Sep 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b5 b5 b5 approved these changes

Assignees

@dustmop dustmop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustmop @b5