Skip to content

Commit

Permalink
refactor: modify add dataset modal language
Browse files Browse the repository at this point in the history
  • Loading branch information
chriswhong committed Sep 26, 2019
1 parent e84e34f commit 6805693
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion app/actions/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ export function addDatasetAndFetch (peername: string, name: string, path: string
response = await whenOk(fetchMyDatasets(-1))(response)
dispatch(setWorkingDataset(peername, name))
dispatch(setActiveTab('history'))
dispatch(setSelectedListItem('component', DEFAULT_COMPONENT))
dispatch(setSelectedListItem('component', DEFAULT_SELECTED_COMPONENT))
} catch (action) {
throw action
}
Expand Down
1 change: 0 additions & 1 deletion app/components/DatasetSidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ const DatasetSidebar: React.FunctionComponent<DatasetSidebarProps> = (props) =>
}
</div>
</CSSTransition>
{ console.log(!hideCommitNudge, bodyLoaded, statusLoaded, historyLoaded, noHistory, datasetSelected) }
{
!hideCommitNudge && bodyLoaded && statusLoaded && historyLoaded && noHistory && datasetSelected && (
<div className='commit-nudge'>
Expand Down
10 changes: 5 additions & 5 deletions app/components/modals/AddDataset.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const AddDataset: React.FunctionComponent<AddDatasetProps> = (props) => {
const datasetFolderPath = path.join(datasetPath, datasetName)

onSubmit(peername, datasetName, datasetFolderPath)
.then(() => onDismissed())
.then(() => { onDismissed() })
.catch((action) => {
setDismissable(true)
setLoading(false)
Expand Down Expand Up @@ -126,7 +126,7 @@ const AddDataset: React.FunctionComponent<AddDatasetProps> = (props) => {
return (
<Modal
id="addDataset"
title={'Add a Dataset from the Network'}
title={'Add an Existing Qri Dataset'}
onDismissed={onDismissed}
onSubmit={() => {}}
dismissable={dismissable}
Expand All @@ -135,12 +135,12 @@ const AddDataset: React.FunctionComponent<AddDatasetProps> = (props) => {
<div className='content-wrap'>
<div>
<div className='content'>
<p>Add a dataset that already exists on Qri</p>
<p>Qri dataset references use <span className='code-highlight'>peername/datasetname</span> format. Find datasets on <ExternalLink href='https://qri.cloud'>Qri Cloud</ExternalLink>.</p>
<p>Add an existing dataset by entering its dataset reference, like <span className='code-highlight'>b5/world_bank_population</span></p>
<p>Search for datasets on <ExternalLink href='https://qri.cloud'>Qri Cloud</ExternalLink>.</p>
<DebouncedTextInput
name='datasetName'
label='Dataset Reference'
labelTooltip='Enter a dataset reference'
labelTooltip={'Qri dataset references use [peername]/[datasetname] format'}
tooltipFor='modal-tooltip'
type=''
value={datasetReference}
Expand Down

0 comments on commit 6805693

Please sign in to comment.