fix(HistoryListItem, e2e tests): fix logic bug in HistoryListItem

also adjusts e2e tests, removing the expectation that there will be 'greyed' out items in the history list on the network preview.

app/components/item/HistoryListItem.tsx

@@ -44,7 +44,7 @@ const HistoryListItem: React.FunctionComponent<HistoryListItemProps> = (props) =
         })
       }
       data-tip={allowDisable && foreign ? 'This version is unavailable' : undefined}
-      onClick={() => { if (!allowDisable) props.onClick(path) }}
+      onClick={() => { if (!(foreign && allowDisable)) props.onClick(path) }}
     >
       <div className='icon-column'>
         <div className='history-timeline-line history-timeline-line-top' />

test/e2e/e2e.spec.ts

@@ -294,8 +294,6 @@ describe('Qri End to End tests', function spec () {
       atLocation,
       click,
       onStatusTab,
-      waitForExist,
-      doesNotExist,
       waitForNotExist,
       takeScreenshot
     } = utils
@@ -592,8 +590,6 @@ describe('Qri End to End tests', function spec () {
     // check we are at the right dataset
     await waitForExist('#navbar-breadcrumb')
     await expectTextToContain('#navbar-breadcrumb', registryDatasetName)
-    // history item has foreign class
-    await waitForExist('#HEAD-1.foreign')
 
     if (takeScreenshots) {
       await takeScreenshot(artifactPath('network-preview.png'))
@@ -653,11 +649,6 @@ describe('Qri End to End tests', function spec () {
     // there should be two history items
     const historyItems = await app.client.$$('.history-list-item')
     expect(historyItems.length).toBe(2)
-
-    // first commit should have foreign class
-    await waitForExist('#HEAD-1.foreign')
-    // second commit should not
-    await waitForNotExist('#HEAD-2.foreign')
   })
 
   it('search: clicking a local dataset brings you to the workbench', async () => {