Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TypePicker): create TypePicker and other needed components #390

Merged
merged 4 commits into from
Jan 14, 2020

Commits on Jan 10, 2020

  1. Configuration menu
    Copy the full SHA
    279dd52 View commit details
    Browse the repository at this point in the history
  2. feat(components): add components that build to create TypePicker

    added components:
    - overlay/Overlay: used as a pop over, will call `onCancel` if you click outside fo the div, or click the 'x'. The `navigation` prop is optional. Any `children` will overflow-y scroll.
    - item/DataType.tsx: defines the `DataTypes` type. Wraps the type name, description, and icon. `type` and `description`, are defined and passed down. May want to refactor to keep description and type defined here, and just use the type to determine all content.
    - nav/TabPicker: has size options 'sm' and 'md', and color options 'light' and 'dark'
    - overlay/TypePickerOverlay: a version of `Overlay` that lists the DataTypes and passes through the `navigation` component. `typesAndDescriptions` are defined here.
    - structure/ColumnType: the component used to show the column type with its icon. Is not 'clickable' if there is no 'onClick' func passed down. I a column has more than one type, it will indicate 'multi'
    - structure/TypePicker: takes all these components and creates a TypePicker. Click on the columnType to get a TypePickerOverlay popup. Choose between single or multi mode. The chosen type is kept in the hidden input named for the column (`${column-name}-type`)
    
    This commit also created scss files based on the folder structure:
    - chrome
    - item
    - nav
    - overlay
    - structure
    - type
    
    It also adds a story for each component under the `structure` tab
    ramfox committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    bd901a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Configuration menu
    Copy the full SHA
    2b6bca3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    32d4c5d View commit details
    Browse the repository at this point in the history