fix(*): Welcome, ChoosePeername, AddDataset, CreateDataset #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n interface refer to #42 for reasoning
- renames `ui/setPeername` to `ui/setHasSetPeername` - passes new actions down to `App` component, through `AppContainer` - refactors `onSave` func in OnBoarding - add`acceptEnabled` (accept button enabled) param to `WelcomeTemplate`, which disables the accept button (and adjusts styling) when false
…t want it - also added CSSTransition - adjusted `.error` css
this commit also comments out the tabs in `CreateDataset`, and all other associated code
|
LGTM, one note on #50 I was expecting "Create a Dataset" to make a directory for me with the dataset name, but it just added files to the location I specified. I think this should make a directory, and we should make this clearer to the user. I'm good to merge this, just flagging a UX wish. |
chriswhong
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #41 - bug in TOS page, (change link from
frontendtodesktop)closes #42 - wire up ChoosePeername page
This is closed, however this won't be functioning until qri-io/qri#849
closes #48 - removed 'By Url' tab in AddDataset and add more info and error handling describing what a good dataset reference is
closes #50 - fix CreateDataset submit bug & commented out 'Use existing datafile' tab
This ended up being an error in how we were setting
paramsin the api. Fixed now.closes #73