-
Notifications
You must be signed in to change notification settings - Fork 66
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(Validate): completely overhaul validation to make it work properly
So, turns out a *bunch* of stuff needed fixing when it comes to valiation. We've gone through and cleanup up the following to make validation a better experience. jsonpointer: * added a new "Descendant" method on a pointer to generate child paths jsonschema: * complete overhaul of Validation interface to support multiple errors, consistent error formatting, and added a jsonpointer path to the location of each error dataset/dsio: * added a new "Entry" struct to represent top-level entries in a dataset * overhauled dsio to remove vals package. dsio now works with go prinitive types * CSVReader has been completely reworked to convert entry rows to the types specified by the Structure schema of the reader (this was the root cause of #290) dataset/validate: * added a new Data method that consumes a dsio.EntryReader to validate data that auto-converts incoming data to JSON for validation (a necessary step to work with JSONSchemas) dataset/dsfs: * dsfs.CreateDataset now uses validate.Data dataset: * updated all packages to use new dsio interfaces qri/core: * dataset.Validate now is mainly a wrapper around validate.Data This sets the stage for some exciting stuff in the future, and makes qri work properly / better today. I'm particularly excited to work with the new dsio Reader/Writer interfaces, as they set the stage for filtering & sorting subsections of datasets on the fly closes #290
- Loading branch information
Showing
21 changed files
with
209 additions
and
24,074 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{"left":"me/cities@/map/QmbnworAqqiMBGRoQGfnseRJmsK31UGSAFtWD3Doh4b6xq", "right":"me/cities@/map/QmVZJTaRsiSc5UkpBSzH4yFQXvKKWGkjvGh5rNzueWDNQa"} | ||
{"left":"me/cities@/map/QmYeLPcKPZEyvQzhVgCDcJ8kWjAipwbuw5bB4kFAkrCnmA", "right":"me/cities@/map/QmUC8bnchH1TjWTxzvPzLkksdH7cX4EpvNkXmeK1GSqStV"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{"left":"me/cities@/map/QmbnworAqqiMBGRoQGfnseRJmsK31UGSAFtWD3Doh4b6xq", "right":"me/cities@/map/QmVZJTaRsiSc5UkpBSzH4yFQXvKKWGkjvGh5rNzueWDNQa","format":"plusMinusColor"} | ||
{"left":"me/cities@/map/QmYeLPcKPZEyvQzhVgCDcJ8kWjAipwbuw5bB4kFAkrCnmA", "right":"me/cities@/map/QmUC8bnchH1TjWTxzvPzLkksdH7cX4EpvNkXmeK1GSqStV","format":"plusMinusColor"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.