fix(remove): don't fail if remove encounters an issue traversing qfs …

…history

this is a bit of a stop-gap for now, but users are seeing bad errors when dataset histories aren't fully persisted & they attempt to delete. This may end up causing stray-pinning, and the long-term solution for that is to use logbook for this remove task. We can also use logbook to identify stray pins & reclaim the space

closes #989

base/dataset.go

@@ -305,8 +305,8 @@ func RemoveNVersionsFromStore(ctx context.Context, r repo.Repo, ref *repo.Datase
 	for i != 0 {
 		// decrement our counter
 		i--
-		// unpin dataset
-		if err = UnpinDataset(ctx, r, curr); err != nil {
+		// unpin dataset, ignoring "not pinned" errors
+		if err = UnpinDataset(ctx, r, curr); err != nil && !strings.Contains(err.Error(), "not pinned") {
 			return err
 		}
 		// if no previous path, break
@@ -316,7 +316,12 @@ func RemoveNVersionsFromStore(ctx context.Context, r repo.Repo, ref *repo.Datase
 		// load previous dataset into prev
 		next, err := dsfs.LoadDatasetRefs(ctx, r.Store(), curr.Dataset.PreviousPath)
 		if err != nil {
-			return err
+			// Note: We want delete to succeed even if datasets are remote, so we don't fail on
+			// this error, and break early instead
+			// TODO (b5) - removing dataset versions should rely on logbook, which is able
+			// to traverse across missing datasets in qfs
+			log.Debugf("error fetching previous: %s", err)
+			break
 		}
 		curr = repo.DatasetRef{
 			Path:    next.Path,

go.mod

@@ -39,8 +39,6 @@ require (
 	github.com/microcosm-cc/bluemonday v1.0.2
 	github.com/minio/blake2b-simd v0.0.0-20160723061019-3f5f724cb5b1
 	github.com/mitchellh/go-homedir v1.1.0
-	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
-	github.com/modern-go/reflect2 v1.0.1 // indirect
 	github.com/mr-tron/base58 v1.1.2
 	github.com/multiformats/go-multiaddr v0.1.1
 	github.com/multiformats/go-multicodec v0.1.6