Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"non pinned or pinned indirectly" #989

Closed
chriswhong opened this issue Oct 29, 2019 · 0 comments · Fixed by #1001
Closed

"non pinned or pinned indirectly" #989

chriswhong opened this issue Oct 29, 2019 · 0 comments · Fixed by #1001
Assignees
@b5
Labels
bug code that is not behaving as expected
Milestone
v0.9.1

Comments

@chriswhong
Copy link
Contributor

world_bank_population_—more_◂_qri_log_chriswhong_world_bank_population—_113×41

I attempted to run qri remove --all on a dataset after moving the linked directory to the trash, and got this error. Moved it back, but it seems there was never a .qri-ref in that folder.

I moved the folder back to the trash and pressed "Link to filesystem" in Qri desktop, it re-created the folder and everything was back to normal.
@chriswhong chriswhong added the bug code that is not behaving as expected label Oct 29, 2019
@b5 b5 self-assigned this Nov 5, 2019
@b5 b5 added this to the v0.9.2 milestone Nov 5, 2019
b5 added a commit that referenced this issue Nov 5, 2019
@b5
fix(remove): don't fail if remove encounters an issue traversing qfs …
f842273 
…history

this is a bit of a stop-gap for now, but users are seeing bad errors when dataset histories aren't fully persisted & they attempt to delete. This may end up causing stray-pinning, and the long-term solution for that is to use logbook for this remove task. We can also use logbook to identify stray pins & reclaim the space

closes #989
@b5 b5 mentioned this issue Nov 5, 2019
Merged
@b5 b5 closed this as completed in #1001 Nov 5, 2019
@b5 b5 mentioned this issue Nov 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b5 b5

Labels
bug code that is not behaving as expected
Projects
None yet
Milestone
v0.9.1
Development

Successfully merging a pull request may close this issue.

fix(remove): don't fail if remove encounters an issue traversing qfs history qri-io/qri
2 participants
@b5 @chriswhong