Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick a default port that isn't 3000 #163

Closed
b5 opened this issue Dec 8, 2017 · 0 comments · Fixed by #164
Closed

Pick a default port that isn't 3000 #163

b5 opened this issue Dec 8, 2017 · 0 comments · Fixed by #164
Assignees
@b5
Milestone
0.1.0

Comments

@b5
Copy link
Member

b5 commented Dec 8, 2017

3000's a crowded number on dev machines. I'm thinking we go with 2503. because it's higher than 1023 (safe), it's a prime number (dope), and I've always been a fan of the number 25 (bias). That's about as much rationale as we need.
@b5 b5 added this to the 0.1.0 milestone Dec 8, 2017
@b5 b5 self-assigned this Dec 8, 2017
@b5 b5 added the in progress label Dec 8, 2017
b5 added a commit that referenced this issue Dec 8, 2017
@b5
feat(RPC): change default port, provide RPC listener
92e42ae 
so we've been planning to do this for a while, but a proper
reason to do so hadn't come up until we needed to be able to
use the CLI while a server is running (while ssh'd into a container).

This commit is a spike that only supports DatasetRequests for now
while I work out the details of this pattern.

also, closes #163
@b5 b5 mentioned this issue Dec 8, 2017
Merged
@b5 b5 closed this as completed in #164 Dec 12, 2017
@ghost ghost removed the in progress label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b5 b5

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

feat(RPC): change default port, provide RPC listener qri-io/qri
1 participant
@b5