Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Support for readOnly API mode, use auth tokens for privileged access #1723

Closed
b5 opened this issue Mar 24, 2021 · 0 comments · Fixed by #1819
Closed

Remove Support for readOnly API mode, use auth tokens for privileged access #1723

b5 opened this issue Mar 24, 2021 · 0 comments · Fixed by #1819
Labels
API JSON API issues config issues surrounding qri configuration Needs Migration
Milestone
v0.11.0

Comments

@b5
Copy link
Member

b5 commented Mar 24, 2021

In the next release we should remove support for api.ReadOnly: true entirely, marking the configuration field as deprecated. qri commands should fail if api.ReadOnly is set to true with an error message about configuration.

ReadOnly mode was a half-baked effort to get around not having a proper authorization scheme. Once we have a mechanism for authentication in place, we should remove it entirely.

cc @Arqu, as this impacts cloud more than anything.
@b5 b5 added API JSON API issues config issues surrounding qri configuration labels Mar 24, 2021
@b5 b5 added this to the v0.10.0 milestone Mar 24, 2021
@b5 b5 mentioned this issue Mar 24, 2021
Merged
@ramfox ramfox mentioned this issue Mar 27, 2021
Merged
@ramfox ramfox mentioned this issue Apr 8, 2021
Closed
29 tasks
@b5 b5 modified the milestones: v0.10.0, v0.11.0 Apr 13, 2021
b5 added a commit that referenced this issue Jul 5, 2021
@b5
refactor(config.API): migration changes API config fields
75b6d4c 
add in a number of changes we've been waiting for a config migration to make
to config.Config.API:

* rename DisableWebui -> EnableWebui & default to true
* drop all support for "readonly" mode, remove config field
* remove "DisconnectAfter". disconnects are now handled with context cancellations
* remove "WebsocketAddress": websockets are now served over the main API port

migration 3-to-4 always sets EnableWebui to "true"

closes #1723, closes #1619, closes #1618

BREAKING CHANGE: config.API fields have changed
@b5 b5 mentioned this issue Jul 5, 2021
Merged
@b5 b5 closed this as completed in #1819 Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API JSON API issues config issues surrounding qri configuration Needs Migration
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

update dependencies, migrate configuration from revision 3 to 4 qri-io/qri
1 participant
@b5