Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug on setup: setting peername #328

Closed
ramfox opened this issue Mar 30, 2018 · 0 comments · Fixed by #330
Closed

bug on setup: setting peername #328

ramfox opened this issue Mar 30, 2018 · 0 comments · Fixed by #330
Assignees
@b5
Labels
bug code that is not behaving as expected
Milestone
0.3.0

Comments

@ramfox
Copy link
Member

ramfox commented Mar 30, 2018 •
edited
Loading

On setup, when you enter a personal peername (and not just use the generated one), this peername gets saved to the config file, but does not get updated in the store (the profile.json file).

Since the profile is where we pull the peername for saving datasets/looking up datasets, this means that our datasets are getting saved in the store as auto_generated_color_and_dog_name/datasetname rather than ramfox/datasetname

Also, if I use the qri config set profile.peername newName it doesn't go through the store and update the datasets with the new peername
@ramfox ramfox added the bug code that is not behaving as expected label Mar 30, 2018
@ramfox ramfox added this to the 0.2.1 milestone Mar 30, 2018
b5 added a commit that referenced this issue Apr 3, 2018
@b5
fix(config): fix issues created by config overhaul
501cf9a 
changes to config introduced a number of problems that need addressing. Namely
profile mismatches between fsrepo & the config profile storage, port mismatches,
a few default configuration errors, and some missing / bad error reporting
around configuration loading.

closes #328, closes #329
@b5 b5 mentioned this issue Apr 3, 2018
Merged
@ghost ghost assigned b5 Apr 3, 2018
@ghost ghost added the in progress label Apr 3, 2018
@b5 b5 closed this as completed in #330 Apr 3, 2018
@ghost ghost removed the in progress label Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b5 b5

Labels
bug code that is not behaving as expected
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

fix(config): fix issues created by config overhaul qri-io/qri
2 participants
@b5 @ramfox