Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep getting odd log messages #357

Closed
ramfox opened this issue Apr 12, 2018 · 1 comment
Closed

Keep getting odd log messages #357

ramfox opened this issue Apr 12, 2018 · 1 comment
Milestone
0.3.1

Comments

@ramfox
Copy link
Member

ramfox commented Apr 12, 2018 •
edited
Loading

I keep getting log messages when I qri connect or when I qri config set a field:

10:49:21.977 ERROR     fsrepo: invalid character '3' after top-level value profile_store.go:31
10:51:54.375 ERROR     fsrepo: invalid character 'M' after top-level value profile_store.go:31

But not sure what they are referring to.
@b5 b5 mentioned this issue Apr 17, 2018
Merged
b5 added a commit that referenced this issue Apr 23, 2018
@b5
fix(fsrepo.Profiles): add file lock for peers.json
f692d55 
we've been getting all sorts of bad json from not guarding peers.json
from concurrent reads & writes. This makes some initial inroads on the
problem, but isn't to be trusted until comprehensive tests are written.

makes more inroads on #357
@b5 b5 mentioned this issue Apr 23, 2018
Merged
@b5 b5 added this to the 0.3.1 milestone Apr 25, 2018
@b5
Copy link
Member

b5 commented Apr 25, 2018

Ok turns out this was a race condition with file writing, which has been addressed by #368. There's still a chance this'll happen but it should be far less common.

@b5 b5 closed this as completed Apr 25, 2018
ramfox pushed a commit that referenced this issue May 3, 2018
@b5 @ramfox
fix(fsrepo.Profiles): add file lock for peers.json
89e5681 
we've been getting all sorts of bad json from not guarding peers.json
from concurrent reads & writes. This makes some initial inroads on the
problem, but isn't to be trusted until comprehensive tests are written.

makes more inroads on #357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.1
Development

No branches or pull requests
2 participants
@b5 @ramfox