-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
things specified in dataset.yaml
should override transforms
#456
Comments
b5
added a commit
that referenced
this issue
Jun 12, 2018
b5
added a commit
that referenced
this issue
Jun 12, 2018
ugh I screwed up my commits & don't have time to de-couple them. This commit also refactors our tests in the cmd package to make them more readable / sensible closes #456
b5
added a commit
that referenced
this issue
Jun 12, 2018
ugh I screwed up my commits & don't have time to de-couple them. This commit also refactors our tests in the cmd package to make them more readable / sensible closes #456
b5
added a commit
that referenced
this issue
Jun 12, 2018
ugh I screwed up my commits & don't have time to de-couple them. This commit also refactors our tests in the cmd package to make them more readable / sensible closes #456
ghost
removed
the
in progress
label
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So we've made transforms, dope. Transforms have sweet convenience methods like
qri.set_meta("title", "this is a title")
, also dope.But this creates ambiguity. When I set a
meta.title
in both the transform and indataset.yaml
, what's supposed to happen? This is effectively the same thing as supplying input data on the frontend via & API call to a dataset that also includes a transform.I'd like to vote for things specified in dataset.yaml overriding everything. To me this places a greater burden on those writing transformations (who now need to think about weather or not a user has provided field foo already). But at least in that case they conditional statements to work around this stuff.
What's important to me here is to prioritize declarative statements put forth by the end user. If I explicitly add
meta.title: "my dataset"
, I don't think the transform should get to override me. On the other hand, if I provide nothing and the transform auto-sets a title for me, I'm delighted. If this irritates me, I have a way to modify the output without knowing how the transform works.Holler if you think this is silly
The text was updated successfully, but these errors were encountered: