Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: unable to get datasets using just peername/datasetname #479

Closed
ramfox opened this issue Jul 12, 2018 · 1 comment
Closed

bug: unable to get datasets using just peername/datasetname #479

ramfox opened this issue Jul 12, 2018 · 1 comment
Assignees
@ramfox
Labels
bug code that is not behaving as expected

Comments

@ramfox
Copy link
Member

ramfox commented Jul 12, 2018

Getting a peer's dataset using peername/datasetname is returning an error:

{
  "meta": {
    "code": 404,
    "error": "cannot find peer dataset"
  }
}

However, using a more hydrated datasetRef works, for example:
ramfox/lolstats2016/at/ipfs/QmaH5YWMMvsZQb2a1CxWb7QNdCXqEyqNtpmqye97PoZZKi works just fine
@ramfox ramfox added the bug code that is not behaving as expected label Jul 12, 2018
@ramfox ramfox self-assigned this Jul 12, 2018
@osterbit osterbit mentioned this issue Jul 27, 2018
Closed
@dustmop dustmop mentioned this issue Jul 30, 2018
Closed
dustmop added a commit that referenced this issue Aug 22, 2018
@dustmop
fix(get): Get completely reworked to function better
a1ba693 
Get method written so that it is used by both cmd/ and api/. Follows the new
guideline set out by #519, moving nearly all the logic from lib/ to actions/.
Logic which is specific to the command-line, selecting parts of a dataset
using a path, moved up a level to the cmd/ package.

Get can now be used to retrieve info about local and remote datasets, from
both command-line and api server. Fixes #509, #479 #397, and possibly others.

Clears the way to merging `body` into `get` in a future PR.

Breaks ability to `get` multiple datasets at once.
dustmop added a commit that referenced this issue Aug 22, 2018
@dustmop
fix(get): Get completely reworked to function better
32c079f 
Get method written so that it is used by both cmd/ and api/. Follows the new
guideline set out by #519, moving nearly all the logic from lib/ to actions/.
Logic which is specific to the command-line, selecting parts of a dataset
using a path, moved up a level to the cmd/ package.

Get can now be used to retrieve info about local and remote datasets, from
both command-line and api server. Fixes #509, #479 #397, and possibly others.

Clears the way to merging `body` into `get` in a future PR.

Breaks ability to `get` multiple datasets at once.
@dustmop dustmop mentioned this issue Aug 22, 2018
Merged
dustmop added a commit that referenced this issue Aug 23, 2018
@dustmop
fix(get): Get completely reworked to function better
7c0cc8d 
Get method written so that it is used by both cmd/ and api/. Follows the new
guideline set out by #519, moving nearly all the logic from lib/ to actions/.
Logic which is specific to the command-line, selecting parts of a dataset
using a path, moved up a level to the cmd/ package.

Get can now be used to retrieve info about local and remote datasets, from
both command-line and api server. Fixes #509, #479 #397, and possibly others.

Clears the way to merging `body` into `get` in a future PR.

Breaks ability to `get` multiple datasets at once.
@ramfox
Copy link
Member Author

ramfox commented Oct 4, 2018

closed by #520

@ramfox ramfox closed this as completed Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramfox ramfox

Labels
bug code that is not behaving as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ramfox