Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(read-only): edits to api read-only #577

Closed
1 of 3 tasks
ramfox opened this issue Oct 11, 2018 · 2 comments
Closed
1 of 3 tasks

fix(read-only): edits to api read-only #577

ramfox opened this issue Oct 11, 2018 · 2 comments
Assignees
@ramfox
Labels
API JSON API issues feat A code change that adds functionality
Milestone
v0.6.3

Comments

@ramfox
Copy link
Member

ramfox commented Oct 11, 2018 •
edited by dustmop
Loading

Changes to qri to get frontend read-only functionality to work:

  • get requests on profile picture and profile poster should be allowed through
  • lib.Info function should add the online field to the profilePod before returning. (The /peers list endpoint calls to the lib.Peers, which calls action.ListPeers. action.ListPeers adds the online fields, which is why we get the correct online-ness when we are not in read-only mode: the frontend usually gets all its profile info from this /peers endpoint)
  • perhaps allow GET requests to the /peers endpoint, this depends on what our read-only frontend landing page is going to be
@ramfox ramfox self-assigned this Oct 11, 2018
@ramfox ramfox mentioned this issue Oct 11, 2018
Closed
5 tasks
@b5 b5 added the feat A code change that adds functionality label Nov 12, 2018
dustmop added a commit that referenced this issue Nov 29, 2018
@dustmop
feat(online): Set Online flag for peers when using lib.Info. Cleanups.
4542056 
When getting Info for a peer, set the Online flag appropriately, to match
the behavior of lib.List (peers.go). Do this by checking the other connected
peers that are known to be online, and also checking if you yourself are online.

Fixes part 2 of #577.
This was referenced Nov 29, 2018
Merged
Merged
@dustmop
Copy link
Contributor

dustmop commented Dec 4, 2018

get requests on profile picture and profile poster should be allowed through

These already work, but need to be accessed through the paths "/profile/photo?peername=<peer>" and "/profile/poster?peername=<peer>". Currently, the frontend is using "/ipfs/<ipfs path>", which is disabled in read-only mode.

@b5 b5 added the API JSON API issues label Dec 5, 2018
@b5 b5 added this to the v0.6.2 milestone Dec 19, 2018
@b5 b5 added the ready label Dec 19, 2018
@b5
Copy link
Member

b5 commented Jan 22, 2019

I think this is closable. can you confirm @ramfox?

@b5 b5 modified the milestones: v0.6.2, v0.6.3 Jan 22, 2019
@b5 b5 closed this as completed Feb 2, 2019
@ghost ghost removed the ready label Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramfox ramfox

Labels
API JSON API issues feat A code change that adds functionality
Projects
None yet
Milestone
v0.6.3
Development

No branches or pull requests
3 participants
@b5 @dustmop @ramfox