You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// TODO - the fact that we need to completely re-supply the transform function
// here is a bug. There's currently no way to supply secrets to a transform without
// recalling the previous version. Because of this, I think secrets need to be adjusted
// to be completely out-of-band to datasets, and instead plumbed down from a new field
// lib.SaveParams.Secrets. The Secrets field on dataset.DatasetPod should be removed
Syntax: "starlark",
Config: map[string]interface{}{
"foo": "config",
},
Secrets: map[string]string{
"bar": "secret",
},
ScriptBytes: []byte(`def transform(ds,ctx):
ctx.get_config("foo")
ctx.get_secret("bar")
bd = ds.get_body()
bd.append("hey")
ds.set_body(bd)`),
},
Because of this, I think secrets need to be adjusted to be completely out-of-band to datasets, and instead plumbed down from a new field lib.SaveParams.Secrets. The Secrets field on dataset.DatasetPod should be removed
The text was updated successfully, but these errors were encountered:
this came from work on another PR, but secrets should be completely separate from datasets, and need to be plumbed through the call stack as such
closes#609
Code that outlines the issue is in this test:
qri/actions/dataset_test.go
Lines 280 to 299 in 0096995
Because of this, I think secrets need to be adjusted to be completely out-of-band to datasets, and instead plumbed down from a new field lib.SaveParams.Secrets. The Secrets field on dataset.DatasetPod should be removed
The text was updated successfully, but these errors were encountered: