Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ListParams): address zero-indexing error in ListParams #101

Merged
merged 1 commit into from
Nov 8, 2017
Merged

fix(ListParams): address zero-indexing error in ListParams #101

merged 1 commit into from
Nov 8, 2017

Conversation

b5
Copy link
Member

@b5 b5 commented Nov 7, 2017

ListParamsFromRequest was not properly accounting for page=1 being an offset of 0.

@b5
fix(ListParams): address zero-indexing error in ListParams
c317b28 
ListParamsFromRequest was not properly accounting for page=1 being an offset of 0.
@ghost ghost assigned b5 Nov 7, 2017
@ghost ghost added the in progress label Nov 7, 2017
@b5 b5 requested a review from osterbit November 7, 2017 19:33
osterbit
osterbit approved these changes Nov 7, 2017
View reviewed changes
Copy link
Contributor

@osterbit osterbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕹💽🔮👍

@b5 b5 merged commit 8540c49 into master Nov 8, 2017
@ghost ghost removed the in progress label Nov 8, 2017
@b5 b5 deleted the fix/list_params branch November 8, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterbit osterbit osterbit approved these changes

Assignees

@b5 b5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b5 @osterbit