Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(event): wiring watchfs up to FSI events #1142

Merged
merged 1 commit into from
Feb 27, 2020
Merged

refactor(event): wiring watchfs up to FSI events #1142

merged 1 commit into from
Feb 27, 2020

Conversation

b5
Copy link
Member

@b5 b5 commented Feb 27, 2020

@b5 b5 added refactor A code change that neither fixes a bug nor adds a feature event bus Issues with events & coordination using the event.Bus labels Feb 27, 2020
@b5 b5 requested a review from dustmop February 27, 2020 21:49
@b5 b5 self-assigned this Feb 27, 2020
dustmop
dustmop approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b5 b5 merged commit 1ccc244 into master Feb 27, 2020
@b5 b5 deleted the feat_watchfs_events branch February 27, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustmop dustmop dustmop approved these changes

Assignees

@b5 b5

Labels
event bus Issues with events & coordination using the event.Bus refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b5 @dustmop