test(fetch): Rewrite fetch test. Don't run connect, test expectations. #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustmop
force-pushed
the
rewrite-fetch-test
branch
2 times, most recently
from
c2d986b
to
1a7d591
Compare
dustmop
force-pushed
the
rewrite-fetch-test
branch
from
1a7d591
to
fdf4fbb
Compare
b5
approved these changes
Mar 21, 2020
Comment on lines
+22
to
+23
| // TODO(dustmop): Move most of the below hooks into a common testRunner. Maybe the basic | ||
| // TestRunner will work? |
There was a problem hiding this comment.
The test runner itself looks like it's worth a little scrutiny, but agree with putting a TODO here & bundling up examining the test runner for another day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the TestFetchCommand to fix a number of problems. No longer runs "qri connect". Doesn't use the 2503 port. No longer serves RPC and Websockets. Removes the 5 second wait. Actually inspects the output of
logandfetchto validate that they're working, with stable timestamps. Should fix a number of flakey tests and overall run faster.