Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): always fetch dependencies from the network #218

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

b5
Copy link
Member

@b5 b5 commented Feb 1, 2018

peers with outdated packages have run into issues building qri, adding the -u flag to step one of 'make build' should address this.

related: #217

peers with outdated packages have run into issues building qri,
adding the -u flag to step one of 'make build' should address this.

related: #217
@ghost ghost assigned b5 Feb 1, 2018
@ghost ghost added the in progress label Feb 1, 2018
@machawk1
Copy link
Contributor

machawk1 commented Feb 1, 2018

I performed cd $GOPATH; cd src/github.com/qri-io/qri; git checkout 510e5ffb4ab98cad6d1421070c1c4c5340752d5c; make build and it appears to take longer to fetch the dependencies but still chokes on datatogether/warc/reader:

Katja:qri machawk1$ git show --oneline -s
510e5ff (HEAD, origin/always_update_deps) fix(build): always fetch dependencies from the network
Katja:qri machawk1$ make build

1/5 install non-gx deps:

go get -v -u github.com/briandowns/spinner github.com/datatogether/api/apiutil github.com/fatih/color github.com/ipfs/go-datastore github.com/olekukonko/tablewriter github.com/qri-io/analytics github.com/qri-io/bleve github.com/qri-io/dataset github.com/qri-io/doggos github.com/sirupsen/logrus github.com/spf13/cobra github.com/spf13/viper github.com/qri-io/varName github.com/qri-io/datasetDiffer github.com/datatogether/cdxj
github.com/briandowns/spinner (download)
github.com/fatih/color (download)
github.com/datatogether/api (download)
github.com/ipfs/go-datastore (download)
github.com/jbenet/goprocess (download)
github.com/satori/go.uuid (download)
github.com/olekukonko/tablewriter (download)
github.com/mattn/go-runewidth (download)
github.com/qri-io/analytics (download)
github.com/qri-io/bleve (download)
Fetching https://golang.org/x/net/context?go-get=1
Parsing meta tags from https://golang.org/x/net/context?go-get=1 (status code 200)
get "golang.org/x/net/context": found meta tag get.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at https://golang.org/x/net/context?go-get=1
get "golang.org/x/net/context": verifying non-authoritative meta tag
Fetching https://golang.org/x/net?go-get=1
Parsing meta tags from https://golang.org/x/net?go-get=1 (status code 200)
golang.org/x/net (download)
github.com/syndtr/goleveldb (download)
github.com/golang/snappy (download)
github.com/steveyen/gtreap (download)
github.com/golang/protobuf (download)
github.com/blevesearch/go-porterstemmer (download)
github.com/blevesearch/segment (download)
github.com/qri-io/dataset (download)
github.com/jbenet/go-base58 (download)
github.com/multiformats/go-multihash (download)
github.com/minio/blake2b-simd (download)
github.com/minio/sha256-simd (download)
github.com/mr-tron/base58 (download)
github.com/spaolacci/murmur3 (download)
Fetching https://golang.org/x/crypto/blake2s?go-get=1
Parsing meta tags from https://golang.org/x/crypto/blake2s?go-get=1 (status code 200)
get "golang.org/x/crypto/blake2s": found meta tag get.metaImport{Prefix:"golang.org/x/crypto", VCS:"git", RepoRoot:"https://go.googlesource.com/crypto"} at https://golang.org/x/crypto/blake2s?go-get=1
get "golang.org/x/crypto/blake2s": verifying non-authoritative meta tag
Fetching https://golang.org/x/crypto?go-get=1
Parsing meta tags from https://golang.org/x/crypto?go-get=1 (status code 200)
golang.org/x/crypto (download)
Fetching https://golang.org/x/crypto/sha3?go-get=1
Parsing meta tags from https://golang.org/x/crypto/sha3?go-get=1 (status code 200)
get "golang.org/x/crypto/sha3": found meta tag get.metaImport{Prefix:"golang.org/x/crypto", VCS:"git", RepoRoot:"https://go.googlesource.com/crypto"} at https://golang.org/x/crypto/sha3?go-get=1
get "golang.org/x/crypto/sha3": verifying non-authoritative meta tag
Fetching https://leb.io/hashland/keccakpg?go-get=1
Parsing meta tags from https://leb.io/hashland/keccakpg?go-get=1 (status code 200)
get "leb.io/hashland/keccakpg": found meta tag get.metaImport{Prefix:"leb.io/hashland", VCS:"git", RepoRoot:"https://github.com/tildeleb/hashland"} at https://leb.io/hashland/keccakpg?go-get=1
get "leb.io/hashland/keccakpg": verifying non-authoritative meta tag
Fetching https://leb.io/hashland?go-get=1
Parsing meta tags from https://leb.io/hashland?go-get=1 (status code 200)
leb.io/hashland (download)
github.com/qri-io/jsonschema (download)
github.com/qri-io/jsonpointer (download)
github.com/qri-io/doggos (download)
github.com/sirupsen/logrus (download)
Fetching https://golang.org/x/crypto/ssh/terminal?go-get=1
Parsing meta tags from https://golang.org/x/crypto/ssh/terminal?go-get=1 (status code 200)
get "golang.org/x/crypto/ssh/terminal": found meta tag get.metaImport{Prefix:"golang.org/x/crypto", VCS:"git", RepoRoot:"https://go.googlesource.com/crypto"} at https://golang.org/x/crypto/ssh/terminal?go-get=1
get "golang.org/x/crypto/ssh/terminal": verifying non-authoritative meta tag
Fetching https://golang.org/x/sys/unix?go-get=1
Parsing meta tags from https://golang.org/x/sys/unix?go-get=1 (status code 200)
get "golang.org/x/sys/unix": found meta tag get.metaImport{Prefix:"golang.org/x/sys", VCS:"git", RepoRoot:"https://go.googlesource.com/sys"} at https://golang.org/x/sys/unix?go-get=1
get "golang.org/x/sys/unix": verifying non-authoritative meta tag
Fetching https://golang.org/x/sys?go-get=1
Parsing meta tags from https://golang.org/x/sys?go-get=1 (status code 200)
golang.org/x/sys (download)
github.com/spf13/cobra (download)
github.com/spf13/pflag (download)
github.com/spf13/viper (download)
github.com/fsnotify/fsnotify (download)
github.com/hashicorp/hcl (download)
github.com/magiconair/properties (download)
github.com/mitchellh/mapstructure (download)
github.com/pelletier/go-toml (download)
github.com/spf13/afero (download)
Fetching https://golang.org/x/text/transform?go-get=1
Parsing meta tags from https://golang.org/x/text/transform?go-get=1 (status code 200)
get "golang.org/x/text/transform": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/transform?go-get=1
get "golang.org/x/text/transform": verifying non-authoritative meta tag
Fetching https://golang.org/x/text?go-get=1
Parsing meta tags from https://golang.org/x/text?go-get=1 (status code 200)
golang.org/x/text (download)
Fetching https://golang.org/x/text/unicode/norm?go-get=1
Parsing meta tags from https://golang.org/x/text/unicode/norm?go-get=1 (status code 200)
get "golang.org/x/text/unicode/norm": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/unicode/norm?go-get=1
get "golang.org/x/text/unicode/norm": verifying non-authoritative meta tag
github.com/spf13/cast (download)
github.com/spf13/jwalterweatherman (download)
Fetching https://gopkg.in/yaml.v2?go-get=1
Parsing meta tags from https://gopkg.in/yaml.v2?go-get=1 (status code 200)
get "gopkg.in/yaml.v2": found meta tag get.metaImport{Prefix:"gopkg.in/yaml.v2", VCS:"git", RepoRoot:"https://gopkg.in/yaml.v2"} at https://gopkg.in/yaml.v2?go-get=1
gopkg.in/yaml.v2 (download)
github.com/qri-io/varName (download)
github.com/qri-io/datasetDiffer (download)
github.com/yudai/gojsondiff (download)
github.com/datatogether/cdxj (download)
github.com/datatogether/warc (download)
github.com/puerkitobio/purell (download)
github.com/PuerkitoBio/urlesc (download)
Fetching https://golang.org/x/net/idna?go-get=1
Parsing meta tags from https://golang.org/x/net/idna?go-get=1 (status code 200)
get "golang.org/x/net/idna": found meta tag get.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at https://golang.org/x/net/idna?go-get=1
get "golang.org/x/net/idna": verifying non-authoritative meta tag
Fetching https://golang.org/x/text/secure/bidirule?go-get=1
Parsing meta tags from https://golang.org/x/text/secure/bidirule?go-get=1 (status code 200)
get "golang.org/x/text/secure/bidirule": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/secure/bidirule?go-get=1
get "golang.org/x/text/secure/bidirule": verifying non-authoritative meta tag
Fetching https://golang.org/x/text/unicode/bidi?go-get=1
Parsing meta tags from https://golang.org/x/text/unicode/bidi?go-get=1 (status code 200)
get "golang.org/x/text/unicode/bidi": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/unicode/bidi?go-get=1
get "golang.org/x/text/unicode/bidi": verifying non-authoritative meta tag
Fetching https://golang.org/x/text/width?go-get=1
Parsing meta tags from https://golang.org/x/text/width?go-get=1 (status code 200)
get "golang.org/x/text/width": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/width?go-get=1
get "golang.org/x/text/width": verifying non-authoritative meta tag
github.com/datatogether/warc
# github.com/datatogether/warc
../../datatogether/warc/encoding.go:21:36: undefined: Record
../../datatogether/warc/encoding.go:24:10: undefined: Record
../../datatogether/warc/encoding.go:30:37: undefined: Records
../../datatogether/warc/reader.go:38:26: undefined: Record
../../datatogether/warc/reader.go:47:37: undefined: Records
../../datatogether/warc/reader.go:70:36: undefined: Record
../../datatogether/warc/reader.go:72:8: undefined: Record
../../datatogether/warc/reader.go:81:17: undefined: recordFormat
../../datatogether/warc/reader.go:93:16: undefined: ParseRecordType
make: *** [build] Error 2

@b5
Copy link
Member Author

b5 commented Feb 1, 2018

hrm, kinda strange. this might be a result of datatogether/warc being a dep of a package, and not explicitly listed for installation. I'm assuming you've tried blowing away the $GOPATH/github.com/datatogether dir entirely?

I'm going to merge this so others can use it, but let's keep chatting on #217

@b5 b5 merged commit 71b0cdc into master Feb 1, 2018
@b5 b5 deleted the always_update_deps branch February 1, 2018 23:39
@ghost ghost removed the in progress label Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants