Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: photo endpoints, mutex fixes, makefile updates #363

Merged
merged 5 commits into from
Apr 17, 2018
Merged

Commits on Apr 16, 2018

  1. refator(api): use /profile/photo & /profile/poster as vanity enapoints

    Similar to the situation we ran into shipping the webapp, readonly mode
    can and should prevent access to anything under the /ipfs/ endpoint,
    which sadly includes profile photos & poster images. To get around this
    we'll use the same trick of hiding photos behind vanity urls.
    
    In an effort to avoid API bloat, I've added these as elements of
    the previously under-used /profile/photo & /profile/poster GET endpoints.
    Both now accept query params for id (which is the profile ID) or peerneme.
    this is going to need some refinement & docs, but it'll work for now.
    b5 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    ed7deff View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2018

  1. test(profile.MemStore): add mutex lock to MemStore access

    this was causing problems in tests, hopefully it'll clean 'em up.
    
    closes #354
    b5 committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    0d3226e View commit details
    Browse the repository at this point in the history
  2. chore(makefile): add update-qri-packages command to makefile

    added a quick makefile action to checkout qri repos & update,
    and documentation to help fix issues encountered rebuilding qri
    after updates.
    also bumped circleci to use go 1.10.1, and removed unused deps
    
    closes #313, closes #237
    b5 committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    348f420 View commit details
    Browse the repository at this point in the history
  3. fix(fsrepo.ProfileStore): add mutex lock

    removing a race condition uncovers ANOTHER RACE CONDITION. On the upside
    this might be the cause of corrupt profile store file writes, here's hoping.
    b5 committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    2d4d9ee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b0e2495 View commit details
    Browse the repository at this point in the history