fix(config migration): add config migration to update p2p.QriBootstrapAddrs #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dustmop
approved these changes
Dec 12, 2018
config/config.go
Outdated
| @@ -15,8 +15,12 @@ import ( | |||
| "github.com/qri-io/jsonschema" | |||
| ) | |||
|
|
|||
| // CurrentConfigVersion is the latest configuration number | |||
| const CurrentConfigVersion = 1 | |||
There was a problem hiding this comment.
So this might be a minor quibble, but I could see an issue with calling this "version". These days, version tends to imply something like semver, and is expected to rarely change its major value, incrementing a minor number more often. Of course we're only using the term "version" internally, but it's still a visible term inside the textual config file. As an alternative, we could use "revision", which is more often used as a monotonically increasing value, like for example a build number.
I don't feel super strongly about this, just a thought.
There was a problem hiding this comment.
Oooh I love this. Seeing the word "Version" not followed by a semver is silly. Will Change.
lib/config.go
Outdated
| @@ -4,6 +4,9 @@ import ( | |||
| "encoding/json" | |||
| "fmt" | |||
|
|
|||
| "github.com/qri-io/ioes" | |||
| "github.com/qri-io/qri/config/migrate" | |||
|
|
|||
lib/config_test.go
Outdated
| @@ -7,6 +7,8 @@ import ( | |||
| "os" | |||
| "testing" | |||
|
|
|||
| "github.com/qri-io/ioes" | |||
|
|
|||
b5
force-pushed
the
config_migrations
branch
from
d049a48
to
3189974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Versionfield the config file, and migrates any configuration that doesn't have