Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(get dataset): return a datasetRef, not a dataset! #701

Merged
merged 2 commits into from
Mar 4, 2019
Merged

fix(get dataset): return a datasetRef, not a dataset! #701

merged 2 commits into from
Mar 4, 2019

Conversation

ramfox
Copy link
Member

@ramfox ramfox commented Mar 1, 2019

Eventually we will move to returning datasets, not datasetRefs, but we will do that as one refactor!

@ramfox
fix(get dataset): return a datasetRef, not a dataset!
6e51a31 
Eventually we will move to returning datasets, not datasetRefs, but we will do that as one refactor!
@ghost ghost assigned ramfox Mar 1, 2019
@ghost ghost added the in progress label Mar 1, 2019
@ramfox ramfox requested a review from b5 March 2, 2019 00:02
b5
b5 approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@b5 b5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely. LGTM

@ramfox ramfox merged commit 6446e54 into master Mar 4, 2019
@ramfox ramfox deleted the getFix branch March 4, 2019 19:29
@ghost ghost removed the in progress label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b5 b5 b5 approved these changes

Assignees

@ramfox ramfox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramfox @b5