-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(render): overhauled qri render, implement RFC0011 #724
Conversation
No longer needed. Instead templates specify which components of a dataset they need BREAKING CHANGE: qri render limit, offset, all parameters have been removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having trouble installing this. Turns out dataset
and starlark
both import a package github.com/360EntSecGroup-Skylar/excelize
. We use it in /starlib/xlsx/xlsx.go
and /dataset/dsio/xlsx.go
, specifically the Rows.Columns()
func.
function signature in the release version of 360EntSecGroup-Skylar/excelize:
func (rows *Rows) Columns() []string
function signature at head:
func (rows *Rows) Columns() ([]string, error)
Our code assumes the function signature at head (which was merged 11 days ago), but when you go get
or run make update-qri-deps
, go will pull the release version. This won't matter once a new version of excelize is released, and it won't matter to anyone who is not compiling Qri, but I wanted to note the trouble I ran into!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
OOooOOok, this PR implements RFC0011.
There are a few other changes worth pointing out:
Qri viz template syntax has changed
This PR completely breaks the existing viz template api, replacing it with the one the RFC describes. I plan to fully document that API & post it up in the next few days. The majority of it is outlined in the RFC.
limit
,offset
andall
params are removed from renderGood riddance. Instead templates now bear the full responsibility of determining how much of the dataset body to read. This is a necessary change now that
save
andupdate
both execute render by default. Speaking of which:qri save
andqri update
both generate visualizations by defaultQri now stores an executed version of the template at
index.html
. Get the old behaviour back with--no-render
.