Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remove): removing a dataset with no history should work #927

Merged
merged 3 commits into from
Sep 13, 2019
Merged

fix(remove): removing a dataset with no history should work #927

merged 3 commits into from
Sep 13, 2019

Commits on Sep 12, 2019

  1. fix(remove): removing a dataset with no history should work

    @b5
    b5 committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    f0ba1a1 View commit details
    Browse the repository at this point in the history

  2. fix(api): remove files field is 'files', not 'delete'

    @b5
    b5 committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    3017723 View commit details
    Browse the repository at this point in the history

  3. fix(fsi.DeleteFiles): attempt to remove files, even on early return 

    early-bails were skipping the call to os.Remove, which meant ErrNoHistory ref removal wasn't trying to remove a (very possibly) empty directory.
    @b5
    b5 committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    711f733 View commit details
    Browse the repository at this point in the history